Cleaned up implementation, added nullability annotations for PFFile.m #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Why was this async before? Wasn't it to ensure that all the progress block ticks finished?
Contributor
Author
There was a problem hiding this comment.
No, not really... It was attached to PFTaskQueue vs PFAsyncTaskQueue, which was safer to use with async APIs.
It's no longer needed. downloadAsync already performs on the background thread, so there is basically no need to do this scheduling here.
nlutsenko
added a commit
that referenced
this pull request
Aug 29, 2015
Cleaned up implementation, added nullability annotations for PFFile.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliments Add nullability annotations for all private headers #133