This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
FusionImages: Improve thumbnail generation once more #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agick's "convert"
rfaga
approved these changes
Apr 3, 2018
|
Cool, tested in my local with pillow and without it, both worked fine. Thanks @amotl ! |
|
Cool, thanks for letting me know! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this will now be using "Pillow" again for thumbnail generation, but will gracefully fall back to ImageMagick's "convert" if anything fails. This should complete the amendments originating from #24 and #25.
As expected, Pillow is way faster than shelling out to
convert. Running image conversion for the "Lentille" example takes almost nine minutes with ImageMagick but just 25 seconds when using Pillow on my machine.With kind regards,
Andreas.