Scale branch #219
Merged
Scale branch #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int16 error. Also there was a 16bit overflow error with the out of range values. Also removed some duplicate out of range and invalid graph defines. 28,296 bytes (98%) of flash of 28,672 bytes. 376 bytes free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes some scaling issues with the graphing. The original code saved and scaled graph points, so the original temperature data was lost. This means that if the graph scaled and then over time the scaling changed to be smaller, the graph would not re-scale correctly.
The solution implements some fixed point math, where temperatures are stored as int16 values of 1/10th temperature resolution. The scaling code is also updated to not loop through the data points when they are added, only when they are displayed. This should decrease the overhead, opening options in the future for more features. Also decreases code size a bit, now ~400 bytes free rather than the ~20 on master.