parse_ident: Use constant when known.

khwilliamson · khwilliamson · commit 81f75d090cc7 · 2025-10-17T12:26:01.000-06:00
We know the contents of *s here; it is a colon.  Just use that instead
of derefencing.
diff --git a/toke.c b/toke.c
@@ -10643,8 +10643,9 @@ S_parse_ident(pTHX_ const char *s, const char * const s_end,
                 goto too_long;
             }
 
-            *(*d)++ = *s++;
-            *(*d)++ = *s++;
+            *(*d)++ = ':';
+            *(*d)++ = ':';
+            s += 2;
         }
         else    /* None of the above means have come to the end of any
                    identifier*/

Original file line number	Diff line number	Diff line change
`@@ -10643,8 +10643,9 @@ S_parse_ident(pTHX_ const char s, const char const s_end,`
`10643`	`10643`	`goto too_long;`
`10644`	`10644`	`}`
`10645`	`10645`
`10646`		`- (d)++ = *s++;`
`10647`		`- (d)++ = *s++;`
	`10646`	`+ (d)++ = ':';`
	`10647`	`+ (d)++ = ':';`
	`10648`	`+ s += 2;`
`10648`	`10649`	`}`
`10649`	`10650`	`else /* None of the above means have come to the end of any`
`10650`	`10651`	`identifier*/`