WIP: Streamlines #20

PeterPetrik · 2019-11-08T13:26:58Z

... todo for official pr ....

src/core/mesh/qgsmeshtracerenderer.cpp

PeterPetrik · 2019-11-08T13:28:43Z

src/core/mesh/qgsmeshtracerenderer.cpp

@@ -0,0 +1,6 @@
+#include "qgsmeshtracerenderer.h"
+
+QgsMeshTraceRenderer::QgsMeshTraceRenderer()


src/core/mesh/qgsmeshtracerenderer.h

PeterPetrik · 2019-11-08T13:29:46Z

src/core/mesh/qgsmeshtracerenderer.h

+ * \note not available in Python bindings
+ * \since QGIS 3.12
+ */
+class QgsMeshVectorValueInterpolatorFromNode: public QgsMeshVectorValueInterpolator


please use terminology consistenty. Face, Vertex, Volume (3D). No nodes, no elements...

PeterPetrik · 2019-11-08T13:30:43Z

tests/src/core/testqgsmeshtrace.cpp

@@ -0,0 +1,123 @@
+/***************************************************************************
+                         testqgsmeshlayer.cpp
+                         --------------------


wrong header

PeterPetrik

good job, keep it going!

PeterPetrik · 2019-11-12T09:12:54Z

src/core/mesh/qgsmeshtracerenderer.cpp

+           point );
+}
+
+QgsMeshVectorValueInterpolator::QgsMeshVectorValueInterpolator( QgsTriangularMesh triangularMesh,


probably you want to pass references, not values?

PeterPetrik · 2019-11-12T09:13:10Z

src/core/mesh/qgsmeshtracerenderer.cpp

+    QgsMeshDataBlock scalarActiveFaceFlagValues ):
+  mTriangularMesh( triangularMesh ),
+  mDatasetValues( datasetVectorValues ),
+  mActiveFaceFlagValue( scalarActiveFaceFlagValues )


mActiveFaceFlagValues (missing s)

PeterPetrik · 2019-11-12T09:13:25Z

src/core/mesh/qgsmeshtracerenderer.cpp

+
+}
+
+QgsMeshVectorValueInterpolator::~QgsMeshVectorValueInterpolator() {}


QgsMeshVectorValueInterpolator::~QgsMeshVectorValueInterpolator() = default

PeterPetrik · 2019-11-12T09:14:59Z

src/core/mesh/qgsmeshtracerenderer.cpp

+
+QgsMeshVectorValueInterpolator::~QgsMeshVectorValueInterpolator() {}
+
+void QgsMeshVectorValueInterpolator::updateFace( const QgsPointXY &point )


I am not sure if you need to first check if the point is in triangle. Isn't it enough to just check if interpolateVectorFromVerticesData is not NaN?

Yes, you are maybe right! But it will depend which of interpolateVectorFromVerticesData or isInTriangleFace is faster. If interpolateVectorFromVerticesData do the job as fast, no need to have the isInTriangleFace function.

that how it is done elsewhere

from spatial index on triangular mesh find just triangles that are in your current bounding box/extent

on those selected triangles do interpolateVectorFromVerticesData to find if inside/ouside na data interpolated

PeterPetrik · 2019-11-12T09:15:24Z

src/core/mesh/qgsmeshtracerenderer.cpp

+  return mFieldResolution;
+}
+
+QgsPointXY QgsMeshTraceField::positionToMapCoordinnate( const QPoint &pixelPosition, const QgsPointXY &positionInPixel )


typo "coordinate"

PeterPetrik · 2019-11-12T09:37:11Z

src/core/mesh/qgsmeshtracerenderer.h

+    bool mValid;
+
+    QgsMeshVectorValueInterpolator *mVectorValueInterpolator;
+    double mVmax;


PeterPetrik · 2019-11-12T09:37:14Z

src/core/mesh/qgsmeshtracerenderer.h

+    QgsMapToPixel mMapToFieldPixel;
+    QSize mFieldSize;
+    QPoint mFieldTopLeftInDeviceCoordinates;
+    bool mValid;


PeterPetrik · 2019-11-12T09:37:50Z

src/core/mesh/qgsmeshtracerenderer.h

+ * \note not available in Python bindings
+ * \since QGIS 3.12
+ */
+class QgsMeshTraceParticule


not sure if it is not "particle" in english

PeterPetrik · 2019-11-12T09:38:22Z

src/core/mesh/qgsmeshtracerenderer.h

+      delete mTraceField;
+    }
+
+    void draw()


implementations to cpp...

PeterPetrik · 2019-11-12T09:38:57Z

src/core/mesh/qgstriangularmesh.h

+   *  NB : tirangle surface = Isleft / 2
+   *  * \since QGIS 3.12
+  */
+  CORE_EXPORT double IsLeft2D( const QgsPoint &p1, const QgsPoint &p2, const QgsPoint &p );


needs to be exported?

PeterPetrik · 2019-11-19T08:11:29Z

please remove file .TODO.kate-swp
please rebase against latest master and squash to 1 or 2 commits

PeterPetrik

looks very good... if you squash the commits to 1 commit, rebase and fix the issues in the review I think we should create official PR in QGIS and close this one

PeterPetrik · 2019-11-19T08:22:31Z

src/app/mesh/qgsmeshrenderervectorsettingswidget.h

@@ -59,6 +59,27 @@ class APP_EXPORT QgsMeshRendererVectorSettingsWidget : public QWidget, private U
    //! Mesh rendering settings changed
    void widgetChanged();

+  private slots:
+    void onSymbologyChanged( int currentIndex )


move implementation to cpp file

PeterPetrik · 2019-11-19T08:25:00Z

src/app/mesh/qgsmeshrenderervectorsettingswidget.h

@@ -69,6 +90,12 @@ class APP_EXPORT QgsMeshRendererVectorSettingsWidget : public QWidget, private U

    QgsMeshLayer *mMeshLayer = nullptr; //not owned
    int mActiveDatasetGroup = -1;
+
+    QList<QWidget *> mArrowSettingsWidget;


I would group the arrow settings widget in one new parent widget in ui file. same with streamlines widgets. and then just hide the whole group.

PeterPetrik · 2019-11-19T08:25:32Z

src/core/mesh/qgsmeshlayerrenderer.cpp

@@ -152,7 +154,7 @@ void QgsMeshLayerRenderer::copyVectorDatasetValues( QgsMeshLayer *layer )
  const int datasetGroupCount = layer->dataProvider()->datasetGroupCount();
  QgsMeshLayerRendererCache *cache = layer->rendererCache();
  if ( ( cache->mDatasetGroupsCount == datasetGroupCount ) &&
-       ( cache->mActiveVectorDatasetIndex == datasetIndex ) )
+       ( cache->mActiveVectorDatasetIndex == datasetIndex ) ) //scalar weight data set can have a different datasetIndex


is this comment still actual?

PeterPetrik · 2019-11-19T08:26:08Z

src/core/mesh/qgsmeshlayerrenderer.h

@@ -33,6 +33,7 @@ class QgsMeshLayer;
 #include "qgsmeshlayer.h"
 #include "qgssymbol.h"
 #include "qgsmeshdataprovider.h"
+#include "qgsmeshtracerenderer.h" //TODO : dispach this file in two files : one with renderer the other one with fields


remove/implement todo comment?

PeterPetrik · 2019-11-19T08:27:51Z

src/core/mesh/qgsmeshrenderersettings.cpp

+  mSeedingDensity = seedingDensity;
+}
+
+


remove extra lines

PeterPetrik · 2019-11-19T08:36:49Z

src/core/mesh/qgsmeshtracerenderer.cpp

+{
+  if ( ! QgsMeshUtils::isInTriangleFace( point, mFaceCache, mTriangularMesh.vertices() ) )
+  {
+    /*the first version of this method uses QgsGeometry::contain to check if the point is in triangles,


this is probably developer comment, best to remove it for production version and also rename the function you want to use .remove the other one

PeterPetrik · 2019-11-19T08:37:27Z

src/core/mesh/qgsmeshtracerenderer.cpp

+    return;
+  }
+
+  QgsPointXY interestZoneTopLeft = deviceMapToPixel.transform( QgsPointXY( interestZoneExtent.xMinimum(), interestZoneExtent.yMaximum() ) );


is this implemented?

PeterPetrik · 2019-11-19T08:39:20Z

src/core/mesh/qgsmeshvectorrenderer.h

    //! Dtor
-    ~QgsMeshVectorRenderer();
+    ~QgsMeshVectorArrowRenderer() override {}


move implementation to cpp. use =default

PeterPetrik · 2019-11-19T08:40:45Z

src/core/mesh/qgstriangularmesh.h

@@ -85,6 +85,10 @@ class CORE_EXPORT QgsTriangularMesh
     */
    int faceIndexForPoint( const QgsPointXY &point ) const ;


I don't know, maybe there are advantages to use GEOS for some context ? Is the first version is used elsewhere ? My QtCreator doesn't find another use...

PeterPetrik · 2019-11-19T08:40:59Z

src/core/mesh/qgstriangularmesh.h

+   * Result: > 0 if on the left
+   *          = 0 if on the line
+   *          < 0 if on the right
+   *  NB : tirangle surface = Isleft / 2


typo: triangle

The icon went missing when porting the algorithm from python to a native

…arts parameter (fixes qgis#32940)

WIP : Needs tests

PeterPetrik · 2019-11-20T12:32:52Z

closing this, best to open official PR!

These references are to objects belonging to another thread, which can cause crashes if the object on the main thread is deleted while the handler is still active Refs a asan report: ==677416==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070029bc278 at pc 0x7f95719ccc45 bp 0x7f94bdd7a310 sp 0x7f94bdd7a300 READ of size 4 at 0x6070029bc278 thread T36 (Thread (pooled)) #0 0x7f95719ccc44 in QgsLine3DSymbol::extrusionHeight() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.h:78 #1 0x7f95674a7c01 in QgsBufferedLine3DSymbolHandler::processFeature(QgsFeature&, Qgs3DRenderContext const&) /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol_p.cpp:126 #2 0x7f9567457045 in operator() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:97 #3 0x7f95674597fd in runFunctor /usr/include/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:70 #4 0x7f956744acf7 in QtConcurrent::RunFunctionTask<void>::run() (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x2adcf7) #5 0x7f956a275d59 (/usr/lib64/libQt5Core.so.5+0xc9d59) #6 0x7f956a27268f (/usr/lib64/libQt5Core.so.5+0xc668f) #7 0x7f956a193431 in start_thread (/usr/lib64/libpthread.so.0+0x9431) #8 0x7f955ad59912 in __GI___clone (/usr/lib64/libc.so.6+0x101912) 0x6070029bc278 is located 56 bytes inside of 72-byte region [0x6070029bc240,0x6070029bc288) freed by thread T0 here: #0 0x7f9572b86b87 in operator delete(void*) (/usr/lib64/libasan.so.6+0xb2b87) #1 0x7f956749c00b in QgsLine3DSymbol::~QgsLine3DSymbol() /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:30 #2 0x7f95719664ca in std::default_delete<QgsAbstract3DSymbol>::operator()(QgsAbstract3DSymbol*) const /usr/include/c++/10/bits/unique_ptr.h:85 #3 0x7f95674428ce in std::unique_ptr<QgsAbstract3DSymbol, std::default_delete<QgsAbstract3DSymbol> >::~unique_ptr() /usr/include/c++/10/bits/unique_ptr.h:361 #4 0x7f9567459eb6 in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 #5 0x7f9567459edd in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 #6 0x7f956746e4db in QgsChunkedEntity::~QgsChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/chunks/qgschunkedentity_p.cpp:122 #7 0x7f9567459358 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:164 #8 0x7f9567459373 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:168 #9 0x7f956a42e960 in QObject::event(QEvent*) (/usr/lib64/libQt5Core.so.5+0x282960) #10 0x7f956ada2062 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x172062) previously allocated by thread T0 here: #0 0x7f9572b86067 in operator new(unsigned long) (/usr/lib64/libasan.so.6+0xb2067) #1 0x7f95674a3018 in qgis::_Unique_if<QgsLine3DSymbol>::_Single_object qgis::make_unique<QgsLine3DSymbol>() /home/nyall/dev/qgis-asan/src/core/qgis.h:425 #2 0x7f956749c0b9 in QgsLine3DSymbol::clone() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:34 #3 0x7f9567458b5f in QgsVectorLayerChunkLoaderFactory::QgsVectorLayerChunkLoaderFactory(Qgs3DMapSettings const&, QgsVectorLayer*, QgsAbstract3DSymbol*, int) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:141 #4 0x7f9567458d88 in QgsVectorLayerChunkedEntity::QgsVectorLayerChunkedEntity(QgsVectorLayer*, double, double, QgsVectorLayer3DTilingSettings const&, QgsAbstract3DSymbol*, Qgs3DMapSettings const&) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:159 #5 0x7f956745558f in QgsVectorLayer3DRenderer::createEntity(Qgs3DMapSettings const&) const /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayer3drenderer.cpp:76 #6 0x7f95673a71c0 in Qgs3DMapScene::addLayerEntity(QgsMapLayer*) /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:693 #7 0x7f95673a5523 in Qgs3DMapScene::onLayerRenderer3DChanged() /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:598 #8 0x7f95673c6c33 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DMapScene::*)()>::call(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x229c33) #9 0x7f95673c5468 in void QtPrivate::FunctionPointer<void (Qgs3DMapScene::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #10 0x7f95673c1748 in QtPrivate::QSlotObject<void (Qgs3DMapScene::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #11 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #12 0x7f956252106c in QgsMapLayer::renderer3DChanged() src/core/qgis_core_autogen/EWIEGA46WW/moc_qgsmaplayer.cpp:702 #13 0x7f9563917a12 in QgsMapLayer::setRenderer3D(QgsAbstract3DRenderer*) /home/nyall/dev/qgis-asan/src/core/qgsmaplayer.cpp:1813 #14 0x7f95719aaf52 in QgsApp3DSymbolWidgetWithPreview::updatePreview(QgsAbstract3DSymbol*) /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:243 #15 0x7f95719a97af in operator() /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:175 #16 0x7f95719ac2dd in call /usr/include/qt5/QtCore/qobjectdefs_impl.h:146 #17 0x7f95719ac24f in call<QtPrivate::List<>, void> /usr/include/qt5/QtCore/qobjectdefs_impl.h:256 #18 0x7f95719ac21e in impl /usr/include/qt5/QtCore/qobjectdefs_impl.h:443 #19 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #20 0x7f95708d15ec in QgsApp3DSymbolWidget::widgetChanged() src/app/qgis_app_autogen/6LADBHSVD5/moc_qgsapp3dsymbolwidget.cpp:144 #21 0x7f95719ae1dd in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QgsApp3DSymbolWidget::*)()>::call(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #22 0x7f95719add9c in void QtPrivate::FunctionPointer<void (QgsApp3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #23 0x7f95719adbfa in QtPrivate::QSlotObject<void (QgsApp3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #24 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #25 0x7f956c91c63e in Qgs3DSymbolWidget::changed() src/gui/qgis_gui_autogen/EWIEGA46WW/moc_qgs3dsymbolwidget.cpp:131 #26 0x7f95719ce2ad in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DSymbolWidget::*)()>::call(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #27 0x7f95719ce014 in void QtPrivate::FunctionPointer<void (Qgs3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #28 0x7f95719cdbfc in QtPrivate::QSlotObject<void (Qgs3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #29 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75)

PeterPetrik commented Nov 8, 2019

View reviewed changes

PeterPetrik commented Nov 12, 2019

View reviewed changes

vcloarec force-pushed the streamlines branch 3 times, most recently from 5d0f0c4 to 736f143 Compare November 19, 2019 04:30

PeterPetrik commented Nov 19, 2019

View reviewed changes

nirvn and others added 22 commits November 19, 2019 16:35

[processing] Fix missing icon for polygon to lines algoritghm

f63c747

The icon went missing when porting the algorithm from python to a native

debian packaging: python-gdal still needed for gdal python scripts

8fedf7c

[processing] Fix wrong label description for the centroid alg's all p…

e109dc6

…arts parameter (fixes qgis#32940)

Add backport bot workflow yml

664223c

Enable some more safe clazy checks

4b8f37d

Fix clazy fully-qualified-moc-types warnings

214bbe9

Add missing Q_OBJECT macro

9fc5d86

Fix typos

fe9e6c6

Remove unused QString

a882ece

Use QHash instead of QMap with pointer key

fd68d8e

Remove unused QString

8f1cf97

Remove unused QString

942b74f

Add missing Q_OBJECT macro

3b03b87

Clear clazy unused variable warning on proj < 6 builds

8522732

Another unused string:

c8bf6a9

Fix clazy warnings

6ce8856

Line based exclusion doesn't seem to work with lambdas...

1c128f9

Identation

986aa71

Move QObject declaration to header

9a2e015

Fix build

0b68834

Fix warning

129165a

Streamlines

4ab2eaf

WIP : Needs tests

vcloarec force-pushed the streamlines branch from 736f143 to 4ab2eaf Compare November 20, 2019 04:12

PeterPetrik closed this Nov 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Streamlines #20

WIP: Streamlines #20

PeterPetrik commented Nov 8, 2019

PeterPetrik Nov 8, 2019

PeterPetrik Nov 8, 2019

PeterPetrik Nov 8, 2019

PeterPetrik left a comment

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

vcloarec Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

PeterPetrik Nov 12, 2019

vcloarec Nov 12, 2019

PeterPetrik commented Nov 19, 2019

PeterPetrik left a comment

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

PeterPetrik Nov 19, 2019

vcloarec Nov 20, 2019

PeterPetrik Nov 19, 2019

PeterPetrik commented Nov 20, 2019

		@@ -0,0 +1,6 @@
		#include "qgsmeshtracerenderer.h"

		QgsMeshTraceRenderer::QgsMeshTraceRenderer()


		}

		QgsMeshVectorValueInterpolator::~QgsMeshVectorValueInterpolator() {}


		QgsMeshVectorValueInterpolator::~QgsMeshVectorValueInterpolator() {}

		void QgsMeshVectorValueInterpolator::updateFace( const QgsPointXY &point )

		@@ -85,6 +85,10 @@ class CORE_EXPORT QgsTriangularMesh
		*/
		int faceIndexForPoint( const QgsPointXY &point ) const ;

WIP: Streamlines #20

WIP: Streamlines #20

Conversation

PeterPetrik commented Nov 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterPetrik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterPetrik commented Nov 19, 2019

PeterPetrik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterPetrik commented Nov 20, 2019