Feature/qgis mobile gps info #3

sklencar · 2018-01-08T10:14:10Z

Related to https://gitlab.cloud.lutraconsulting.co.uk/yorkshiredales/qgis-mobile/issues/18

TODO test

…o feature/qgis-mobile-gps-info

PeterPetrik · 2018-01-08T13:00:55Z

src/quickgui/plugin/qgsquickpositionmarker.qml

+        y: positionMarker.screenPosition.y - height/2
+        width: {
+            if (positionKit.accuracy > 0)
+                QgsQuick.Utils.distanceToMapUnits(mapSettings, positionKit.accuracy, 0, 0, 0) * 2


shouldn't be (accuracyIndicator.x + positionKit.accuracy, accuracyIndicator.y, accuracyIndicator.x + positionKit.accuracy, accuracyIndicator.y)?

PeterPetrik · 2018-01-08T13:02:44Z

src/quickgui/plugin/qgsquickpositionmarker.qml

+        visible: withAccuracy
+        x: positionMarker.screenPosition.x - width/2
+        y: positionMarker.screenPosition.y - height/2
+        width: {


Is this working when positionKit.accuracy changes? Isn't necessary to use binding?

PeterPetrik · 2018-01-08T13:03:46Z

src/quickgui/plugin/qgsquickpositionmarker.qml

@@ -73,6 +75,24 @@ Item {
        id: positionKit
    }

+    Rectangle {


can you add comment that this is actually red circle to show GPS accuracy?

PeterPetrik · 2018-01-08T13:04:21Z

src/quickgui/plugin/qgsquickpositionmarker.qml

@@ -32,6 +33,7 @@ Item {
    property alias mapPosition: wgs84toMapCrs.projectedPosition // in map coordinates
    property alias gpsPosition: positionKit.position // in WGS84 coordinates
    property alias positionKit: positionKit
+    property var withAccuracy: true


can you please add short comment ?

PeterPetrik · 2018-01-08T13:05:32Z

src/quickgui/plugin/qgsquickpositionmarker.qml

@@ -83,4 +103,12 @@ Item {
        width: positionMarker.size
        height: width
    }
+
+    ColorOverlay {


This should gray the marker in case there is no accuracy/GPS position? Or what is the purpose? Can you please add comment?

PeterPetrik · 2018-01-08T13:06:11Z

src/quickgui/qgsquickutils.cpp

@@ -95,6 +98,20 @@ QgsPointXY QgsQuickUtils::transformPoint(QgsCoordinateReferenceSystem srcCrs, Qg
    return pt;
 }

+double QgsQuickUtils::distanceToMapUnits(QgsQuickMapSettings* mapSettings, double x1, double y1, double x2, double y2)
+{
+    QPointF p1 = mapSettings->coordinateToScreen(QgsPoint(x1, y1));


return 0 if mapSettings = 0, otherwise good candidate for coredump

also maybe use const pointer ?

PeterPetrik · 2018-01-08T13:09:16Z

src/quickgui/qgsquickutils.cpp

+    QPointF p1 = mapSettings->coordinateToScreen(QgsPoint(x1, y1));
+    QPointF p2 = mapSettings->coordinateToScreen(QgsPoint(x2, y2));
+
+    QgsDistanceArea* mDistanceArea = new QgsDistanceArea();


possible memory leak in future (imagine e.g. setEllipsoid raise C++ exception) use automatic instance on stack.

PeterPetrik · 2018-01-08T13:10:51Z

src/quickgui/qgsquickutils.h

@@ -43,6 +44,7 @@ class QUICK_EXPORT QgsQuickUtils: public QObject
    Q_INVOKABLE QgsPointXY pointXYFactory(double x, double y) const;
    Q_INVOKABLE QgsPoint pointFactory(double x, double y) const;
    Q_INVOKABLE QgsPointXY transformPoint(QgsCoordinateReferenceSystem srcCrs, QgsCoordinateReferenceSystem destCrs, QgsPointXY srcPoint) const;
+    Q_INVOKABLE double distanceToMapUnits(QgsQuickMapSettings* mapSettings, double x1, double y1, double x2, double y2);


(Optional) Maybe better to pass QgsPoint instead? There is already function Q_INVOKABLE QgsPoint pointFactory(double x, double y) const; to create those from QML if needed.

Added random gps accuracy for testing.

sklencar · 2018-01-08T15:34:31Z

Pushed some changes made according the review. Please, check it.
Please, also check https://gitlab.lutraconsulting.co.uk/yorkshiredales/qgis-mobile/merge_requests/4

Improves toggleAllLayers icon

These references are to objects belonging to another thread, which can cause crashes if the object on the main thread is deleted while the handler is still active Refs a asan report: ==677416==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070029bc278 at pc 0x7f95719ccc45 bp 0x7f94bdd7a310 sp 0x7f94bdd7a300 READ of size 4 at 0x6070029bc278 thread T36 (Thread (pooled)) #0 0x7f95719ccc44 in QgsLine3DSymbol::extrusionHeight() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.h:78 #1 0x7f95674a7c01 in QgsBufferedLine3DSymbolHandler::processFeature(QgsFeature&, Qgs3DRenderContext const&) /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol_p.cpp:126 #2 0x7f9567457045 in operator() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:97 #3 0x7f95674597fd in runFunctor /usr/include/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:70 #4 0x7f956744acf7 in QtConcurrent::RunFunctionTask<void>::run() (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x2adcf7) #5 0x7f956a275d59 (/usr/lib64/libQt5Core.so.5+0xc9d59) #6 0x7f956a27268f (/usr/lib64/libQt5Core.so.5+0xc668f) #7 0x7f956a193431 in start_thread (/usr/lib64/libpthread.so.0+0x9431) #8 0x7f955ad59912 in __GI___clone (/usr/lib64/libc.so.6+0x101912) 0x6070029bc278 is located 56 bytes inside of 72-byte region [0x6070029bc240,0x6070029bc288) freed by thread T0 here: #0 0x7f9572b86b87 in operator delete(void*) (/usr/lib64/libasan.so.6+0xb2b87) #1 0x7f956749c00b in QgsLine3DSymbol::~QgsLine3DSymbol() /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:30 #2 0x7f95719664ca in std::default_delete<QgsAbstract3DSymbol>::operator()(QgsAbstract3DSymbol*) const /usr/include/c++/10/bits/unique_ptr.h:85 #3 0x7f95674428ce in std::unique_ptr<QgsAbstract3DSymbol, std::default_delete<QgsAbstract3DSymbol> >::~unique_ptr() /usr/include/c++/10/bits/unique_ptr.h:361 #4 0x7f9567459eb6 in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 #5 0x7f9567459edd in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 #6 0x7f956746e4db in QgsChunkedEntity::~QgsChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/chunks/qgschunkedentity_p.cpp:122 #7 0x7f9567459358 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:164 #8 0x7f9567459373 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:168 #9 0x7f956a42e960 in QObject::event(QEvent*) (/usr/lib64/libQt5Core.so.5+0x282960) #10 0x7f956ada2062 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x172062) previously allocated by thread T0 here: #0 0x7f9572b86067 in operator new(unsigned long) (/usr/lib64/libasan.so.6+0xb2067) #1 0x7f95674a3018 in qgis::_Unique_if<QgsLine3DSymbol>::_Single_object qgis::make_unique<QgsLine3DSymbol>() /home/nyall/dev/qgis-asan/src/core/qgis.h:425 #2 0x7f956749c0b9 in QgsLine3DSymbol::clone() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:34 #3 0x7f9567458b5f in QgsVectorLayerChunkLoaderFactory::QgsVectorLayerChunkLoaderFactory(Qgs3DMapSettings const&, QgsVectorLayer*, QgsAbstract3DSymbol*, int) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:141 #4 0x7f9567458d88 in QgsVectorLayerChunkedEntity::QgsVectorLayerChunkedEntity(QgsVectorLayer*, double, double, QgsVectorLayer3DTilingSettings const&, QgsAbstract3DSymbol*, Qgs3DMapSettings const&) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:159 #5 0x7f956745558f in QgsVectorLayer3DRenderer::createEntity(Qgs3DMapSettings const&) const /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayer3drenderer.cpp:76 #6 0x7f95673a71c0 in Qgs3DMapScene::addLayerEntity(QgsMapLayer*) /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:693 #7 0x7f95673a5523 in Qgs3DMapScene::onLayerRenderer3DChanged() /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:598 #8 0x7f95673c6c33 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DMapScene::*)()>::call(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x229c33) #9 0x7f95673c5468 in void QtPrivate::FunctionPointer<void (Qgs3DMapScene::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #10 0x7f95673c1748 in QtPrivate::QSlotObject<void (Qgs3DMapScene::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #11 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #12 0x7f956252106c in QgsMapLayer::renderer3DChanged() src/core/qgis_core_autogen/EWIEGA46WW/moc_qgsmaplayer.cpp:702 #13 0x7f9563917a12 in QgsMapLayer::setRenderer3D(QgsAbstract3DRenderer*) /home/nyall/dev/qgis-asan/src/core/qgsmaplayer.cpp:1813 #14 0x7f95719aaf52 in QgsApp3DSymbolWidgetWithPreview::updatePreview(QgsAbstract3DSymbol*) /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:243 #15 0x7f95719a97af in operator() /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:175 #16 0x7f95719ac2dd in call /usr/include/qt5/QtCore/qobjectdefs_impl.h:146 #17 0x7f95719ac24f in call<QtPrivate::List<>, void> /usr/include/qt5/QtCore/qobjectdefs_impl.h:256 #18 0x7f95719ac21e in impl /usr/include/qt5/QtCore/qobjectdefs_impl.h:443 #19 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #20 0x7f95708d15ec in QgsApp3DSymbolWidget::widgetChanged() src/app/qgis_app_autogen/6LADBHSVD5/moc_qgsapp3dsymbolwidget.cpp:144 #21 0x7f95719ae1dd in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QgsApp3DSymbolWidget::*)()>::call(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #22 0x7f95719add9c in void QtPrivate::FunctionPointer<void (QgsApp3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #23 0x7f95719adbfa in QtPrivate::QSlotObject<void (QgsApp3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #24 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) #25 0x7f956c91c63e in Qgs3DSymbolWidget::changed() src/gui/qgis_gui_autogen/EWIEGA46WW/moc_qgs3dsymbolwidget.cpp:131 #26 0x7f95719ce2ad in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DSymbolWidget::*)()>::call(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #27 0x7f95719ce014 in void QtPrivate::FunctionPointer<void (Qgs3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #28 0x7f95719cdbfc in QtPrivate::QSlotObject<void (Qgs3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #29 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75)

viktor.sklencar@lutraconsulting.co.uk added 3 commits January 5, 2018 17:50

Added accuracy identificator and coloring marker according signal.

23cc675

TODO test

Merge branch 'qgis_mobile' of https://github.com/PeterPetrik/QGIS int…

ac52c97

…o feature/qgis-mobile-gps-info

Refactored method

cf96eb8

sklencar requested a review from PeterPetrik January 8, 2018 10:14

PeterPetrik assigned sklencar Jan 8, 2018

PeterPetrik added the enhancement label Jan 8, 2018

PeterPetrik requested changes Jan 8, 2018

View reviewed changes

Refactoring according review.

1eba5dd

Added random gps accuracy for testing.

GPS status label

2fa87b4

PeterPetrik approved these changes Jan 9, 2018

View reviewed changes

PeterPetrik merged this pull request into qgis_mobile Jan 9, 2018

PeterPetrik deleted the feature/qgis-mobile-gps-info branch May 30, 2018 10:32

PeterPetrik pushed a commit that referenced this pull request Dec 11, 2018

Merge pull request #3 from SrNetoChan/pr8612

7945b57

Improves toggleAllLayers icon

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/qgis mobile gps info #3

Feature/qgis mobile gps info #3

sklencar commented Jan 8, 2018

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018 •

edited

Loading

PeterPetrik Jan 8, 2018

PeterPetrik Jan 8, 2018

sklencar commented Jan 8, 2018

Feature/qgis mobile gps info #3

Feature/qgis mobile gps info #3

Conversation

sklencar commented Jan 8, 2018

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018 • edited Loading

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

PeterPetrik Jan 8, 2018

Choose a reason for hiding this comment

sklencar commented Jan 8, 2018

PeterPetrik Jan 8, 2018 •

edited

Loading