Skip to content

Conversation

ImperatorS79
Copy link
Contributor

Description

Fix #1082 .
@madoar Why did you not do it ? ^^

Ready for review

  • Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • json-align and eslint run according to the documentation.
  • Codacy and travis checked.

@madoar
Copy link
Collaborator

madoar commented Sep 7, 2019

I wouldn't say I didn't do it (see #1112), I just forgot to add it to the initial PR where I discovered the issue^^

@plata
Copy link
Collaborator

plata commented Sep 9, 2019

@madoar can it be merged then?

@madoar
Copy link
Collaborator

madoar commented Sep 9, 2019

We can, but it would almost certainly lead to a merge conflict in #1112 if it is ok for you I would prefer to fix the issue as part of #1112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined "filesToExtract" in Xact Script
3 participants