-
Notifications
You must be signed in to change notification settings - Fork 46
Update gdiplus verb #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gdiplus verb #1121
Conversation
Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master
updated Hearthstone (download application directly) (PhoenicisOrg#383)
Merge master
Merge recent commits
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge Master
Merge master
Merge master
Merge master
@ImperatorS79 you need to resolve the merge conflict |
const system32directory = this.wine.system32directory(); | ||
|
||
const setupFile = new Resource() | ||
.wizard(this.wizard()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.wizard()
does not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the same thing in adobe air verb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by you got the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also this.wizard in adobe air verb ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I most likely overlooked it. It shouldn't work because the verb classes don't define a wizard
member field/method. wine
does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update it in this PR too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it can you search the repository for this.wizard()
? This shouldn't appear anywhere in the installers or the verbs.
|
||
remove(`${prefixDirectory}/drive_c/gdiplus/`); | ||
|
||
this.overrideDLL() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.wine.overrideDLL()
Is there a way to write |
What do you mean by |
For example in the adobeair verb. |
Normally this is done. (I think I found everything). |
Description
gdiplus verb does not work anymore, so I updated it (it is now closer to winetricks source)
Ready for review
json-align
andeslint
run according to the documentation.