Skip to content

Conversation

ImperatorS79
Copy link
Contributor

@ImperatorS79 ImperatorS79 commented Sep 9, 2019

Description

gdiplus verb does not work anymore, so I updated it (it is now closer to winetricks source)

Ready for review

  • Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • json-align and eslint run according to the documentation.
  • Codacy and travis checked.

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master
updated Hearthstone (download application directly) (PhoenicisOrg#383)
@madoar
Copy link
Collaborator

madoar commented Sep 10, 2019

@ImperatorS79 you need to resolve the merge conflict

const system32directory = this.wine.system32directory();

const setupFile = new Resource()
.wizard(this.wizard())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.wizard() does not exist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the same thing in adobe air verb

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by you got the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also this.wizard in adobe air verb ^^

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I most likely overlooked it. It shouldn't work because the verb classes don't define a wizard member field/method. wine does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update it in this PR too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do so

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it can you search the repository for this.wizard()? This shouldn't appear anywhere in the installers or the verbs.


remove(`${prefixDirectory}/drive_c/gdiplus/`);

this.overrideDLL()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.wine.overrideDLL()

@Zemogiter
Copy link
Contributor

Is there a way to write .wizard() instead of .wizard(wizard)?

@madoar
Copy link
Collaborator

madoar commented Sep 11, 2019

What do you mean by .wizard()?

@Zemogiter
Copy link
Contributor

For example in the adobeair verb.

@ImperatorS79
Copy link
Contributor Author

ImperatorS79 commented Sep 11, 2019

Normally this is done. (I think I found everything).

@ImperatorS79 ImperatorS79 merged commit 43c053a into PhoenicisOrg:master Sep 11, 2019
@ImperatorS79 ImperatorS79 deleted the gdipl branch September 11, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants