-
Notifications
You must be signed in to change notification settings - Fork 46
Added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer) #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test if the functions are working as expected?
var regeditFileContent = | ||
"REGEDIT4\n" + | ||
"\n" + | ||
"[HKEY_CURRENT_USER\\Software\\Wine\\Direct3D]\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if major
or minor
do have more than one digit (e.g. 4.11)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but at this time max OpenGL is 4.6/3.3/2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Would be nice to have it generic but we can add that later as well.
/** | ||
* enable command stream multi-threading | ||
* @returns {Wine} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to have it more generic (setCSMT(true/false)
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSMT is off by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
/** | ||
* force the Use of GLSL | ||
* @returns {Wine} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to have it more generic (setCSMT(true/false)
).
Please use a more specific title for the PR. E.g. "added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If you have tested that it works, I will merge it.
csmt and MaxVersionGL work, but UseGLSL and DirectDrawRenderer don't |
Everything is working now. |
No description provided.