Skip to content

Conversation

ImperatorS79
Copy link
Contributor

No description provided.

Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test if the functions are working as expected?

var regeditFileContent =
"REGEDIT4\n" +
"\n" +
"[HKEY_CURRENT_USER\\Software\\Wine\\Direct3D]\n" +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if major or minor do have more than one digit (e.g. 4.11)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but at this time max OpenGL is 4.6/3.3/2.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Would be nice to have it generic but we can add that later as well.

/**
* enable command stream multi-threading
* @returns {Wine}
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to have it more generic (setCSMT(true/false)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSMT is off by default

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

/**
* force the Use of GLSL
* @returns {Wine}
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to have it more generic (setCSMT(true/false)).

@plata
Copy link
Collaborator

plata commented Aug 19, 2017

Please use a more specific title for the PR. E.g. "added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer)".

@ImperatorS79 ImperatorS79 changed the title Added useful registery key Added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer Aug 19, 2017
@plata plata changed the title Added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer Added registry functions to Wine (for GL version, CSMT, GLSL, DirectDrawRenderer) Aug 19, 2017
Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you have tested that it works, I will merge it.

@ImperatorS79
Copy link
Contributor Author

ImperatorS79 commented Aug 19, 2017

csmt and MaxVersionGL work, but UseGLSL and DirectDrawRenderer don't
Ps: I have found why

@ImperatorS79
Copy link
Contributor Author

Everything is working now.

@plata plata merged commit 5e4e41d into PhoenicisOrg:master Aug 20, 2017
@ImperatorS79 ImperatorS79 mentioned this pull request Aug 20, 2017
@ImperatorS79 ImperatorS79 deleted the Registery branch August 22, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants