Update VK9 #838
Merged
Update VK9 #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plata
requested changes
Jan 22, 2019
Engines/Wine/Verbs/VK9/script.js
Outdated
| var wizard = SetupWizard(InstallationType.VERBS, "VK9", java.util.Optional.empty()); | ||
| // query desired version (default: 0.28.1) | ||
| var versions = ["0.28.1", "0.28.0", "0.27.0", "0.26.0", "0.25.0", "0.23.0", "0.17.0", "0.16.0", "0.6.0", "0.4.0"]; | ||
| var versions = ["0.29.0", "0.28.1", "0.28.0"]; |
There was a problem hiding this comment.
Add comment why the older versions cannot be selected (just to avoid that someone adds them again later because he thinks they are missing).
plata
requested changes
Jan 23, 2019
Engines/Wine/Verbs/VK9/script.js
Outdated
| var wizard = SetupWizard(InstallationType.VERBS, "VK9", java.util.Optional.empty()); | ||
| // query desired version (default: 0.28.1) | ||
| var versions = ["0.29.0", "0.28.1", "0.28.0"]; | ||
| var versions = ["0.29.0", "0.28.1", "0.28.0"]; //this script is not able to install older version (VK9.conf mandatory) |
plata
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version + version before 0.28.0 will not work with this script (not really useful version since VK9 is still in "alpha")