Add Faudio verb #804

ImperatorS79 · 2019-01-12T11:38:15Z

FAudio will replace OpenAL in wine after 4.0, but I think it is good to have a verb for pre-4.0 and for @Zemogiter to test Space Engineer with it.

However, this needs #791 to be fixed, and I need to execute a .sh inside the prefix.

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master

updated Hearthstone (download application directly) (PhoenicisOrg#383)

Merge master

Merge recent commits

Merge master

Engines/Wine/Verbs/FAudio/script.js

qparis · 2019-01-12T12:48:45Z

Engines/Wine/Verbs/FAudio/script.js

+Wine.prototype.faudio = function () {
+    var setupFile = new Resource()
+        .wizard(this.wizard())
+        .url("https://github.com/Kron4ek/FAudio-Builds/releases/download/19.01/faudio-19.01.tar.xz")


Can we trust this source?

If you want to compile FAudio and provided it yourself later on, you can. I just quickly picked up something from this winetricks issue Winetricks/winetricks#1162 to have a proof of concept and a way to test it for Space Engineers, then I ended up in the two problems I listed.

Zemogiter · 2019-01-14T13:02:45Z

Please fix indentation some lines have tabs.

ImperatorS79 · 2019-01-14T13:23:38Z

Will do when the script actually works.

Zemogiter · 2019-01-14T13:27:31Z

#791 is now fixed have you tried if forEach now works?
@qparis why is running .sh scripts inside a script a bad idea?
Update: tested it using latest local repo and POL5. It stays at extracting the archive.

ImperatorS79 · 2019-01-20T12:43:25Z

Ok, working now.

Zemogiter · 2019-01-21T08:42:49Z

Upon the archive extraction I get this error:

org.phoenicis.tools.archive.ArchiveException: Unable to extract the file
	at org.phoenicis.tools.archive.Tar.uncompress(Tar.java:199)
	at org.phoenicis.tools.archive.Tar.uncompressTarFile(Tar.java:89)
	at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:69)
	at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:45)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2784$3124$\^eval\_.extract-1([utils, functions, filesystem, extract]:140)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2801$395$\^eval\_$cu1$restOf.faudio([engines, wine, verbs, faudio]:24)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2705$723AA$\^eval\_$cu1$restOf.run#L:21(<eval>:32)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2701$5556$\^eval\_$cu1$restOf.go([engines, wine, quick_script, steam_script]:141)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2538$402$\^eval\_.run(<eval>:13)
	at jdk.nashorn.javaadapters.org_phoenicis_scripts_Installer.run(Unknown Source)
	at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$2537$\^eval\_$cu1$restOf.:program(<eval>:43)
	at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:655)
	at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
	at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:527)
	at jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:456)
	at jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:413)
	at jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:409)
	at jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:162)
	at java.scripting/javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264)
	at org.phoenicis.scripts.nashorn.NashornEngine.eval(NashornEngine.java:50)
	at org.phoenicis.scripts.nashorn.NashornScriptInterpreter.runScript(NashornScriptInterpreter.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$runScript$0(BackgroundScriptInterpreter.java:35)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.io.IOException: Error detected parsing the header
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:285)
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextEntry(TarArchiveInputStream.java:552)
	at org.phoenicis.tools.archive.Tar.uncompress(Tar.java:160)
	... 24 more
Caused by: java.lang.IllegalArgumentException: Invalid byte 94 at offset 0 in '^ vP��J?' len=8
	at org.apache.commons.compress.archivers.tar.TarUtils.parseOctal(TarUtils.java:141)
	at org.apache.commons.compress.archivers.tar.TarUtils.parseOctalOrBinary(TarUtils.java:171)
	at org.apache.commons.compress.archivers.tar.TarArchiveEntry.parseTarHeader(TarArchiveEntry.java:1277)
	at org.apache.commons.compress.archivers.tar.TarArchiveEntry.parseTarHeader(TarArchiveEntry.java:1266)
	at org.apache.commons.compress.archivers.tar.TarArchiveEntry.<init>(TarArchiveEntry.java:404)
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:283)
	... 26 more

Maybe it's because you are extracting to the (this.prefixDirectory() + "/FAudio/") instead of (this.prefixDirectory() + "drive_c/FAudio/")

UPDATE: The change I've mentioned just reintroduced the hanging at extraction issue.

ImperatorS79 · 2019-01-21T12:36:50Z

You should rebuild latest git @Zemogiter .

Engines/Wine/Verbs/FAudio/script.js

Zemogiter · 2019-01-21T22:25:35Z

@ImperatorS79 did that the error remains

ImperatorS79 · 2019-01-23T17:23:45Z

@Zemogiter I have just tested it again and it works.

plata · 2019-01-23T17:31:39Z

Engines/Wine/Verbs/FAudio/script.js

-    var faudioVersion = "19.01";
+Wine.prototype.faudio = function (faudioVersion) {
+    if(typeof faudioVersion !== 'string') 
+        var faudioVersion = "19.01";


Does this work? I'm a bit confused because of the var. Doesn't it limit the scope of the variable?

ImperatorS79 added 16 commits August 28, 2017 15:19

Merge pull request #1 from PhoenicisOrg/master

06ad52f

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master

Update script.js

86fd07c

Merge pull request #2 from PhoenicisOrg/master

a6f232b

updated Hearthstone (download application directly) (PhoenicisOrg#383)

Merge pull request #3 from PhoenicisOrg/master

a80aa84

Merge master

Merge pull request #4 from PhoenicisOrg/master

6da4a59

Merge recent commits

Merge pull request #8 from PhoenicisOrg/master

4a11f65

Merge master

Merge pull request #9 from PhoenicisOrg/master

b2d5724

Merge master

Merge pull request #10 from PhoenicisOrg/master

b7d1f0f

Merge master

Merge pull request #11 from PhoenicisOrg/master

533df6e

Merge master

Merge pull request #12 from PhoenicisOrg/master

186e4ed

Merge master

Merge pull request #13 from PhoenicisOrg/master

99cf1db

Merge master

Merge pull request #15 from PhoenicisOrg/master

87999b4

Merge master

Merge pull request #16 from PhoenicisOrg/master

610b258

Merge master

Merge pull request #17 from PhoenicisOrg/master

ad2ea01

Merge master

Add files via upload

10d49cf

Update script.js

cd2985b

qparis reviewed Jan 12, 2019

View reviewed changes

Engines/Wine/Verbs/FAudio/script.js Outdated Show resolved Hide resolved

qparis reviewed Jan 12, 2019

View reviewed changes

ImperatorS79 mentioned this pull request Jan 13, 2019

Phoenicis failed to untar .tar.xz PhoenicisOrg/phoenicis#1766

Closed

Add files via upload

a3b6239

ImperatorS79 added 5 commits January 20, 2019 13:20

Update script.js

6a28e76

Fix oopsie

10a8bb5

Update script.js

debf4a1

Update script.js

b50fcc8

Update script.js

d669885

Update script.js

6980d46

plata requested changes Jan 21, 2019

View reviewed changes

Engines/Wine/Verbs/FAudio/script.js Outdated Show resolved Hide resolved

Update script.js

e8dbc95

plata reviewed Jan 23, 2019

View reviewed changes

Update script.js

8c28987

plata approved these changes Jan 23, 2019

View reviewed changes

ImperatorS79 merged commit 8343f17 into PhoenicisOrg:master Jan 23, 2019

ImperatorS79 deleted the FAudio branch February 2, 2019 13:53

Kreyren mentioned this pull request Mar 8, 2019

Update League Of Legends #797

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Faudio verb #804

Add Faudio verb #804

Uh oh!

ImperatorS79 commented Jan 12, 2019 •

edited

Loading

Uh oh!

Uh oh!

qparis Jan 12, 2019

Uh oh!

ImperatorS79 Jan 12, 2019

Uh oh!

Zemogiter commented Jan 14, 2019

Uh oh!

ImperatorS79 commented Jan 14, 2019

Uh oh!

Zemogiter commented Jan 14, 2019 •

edited

Loading

Uh oh!

ImperatorS79 commented Jan 20, 2019

Uh oh!

Zemogiter commented Jan 21, 2019 •

edited

Loading

Uh oh!

ImperatorS79 commented Jan 21, 2019

Uh oh!

Uh oh!

Zemogiter commented Jan 21, 2019

Uh oh!

ImperatorS79 commented Jan 23, 2019

Uh oh!

plata Jan 23, 2019

Uh oh!

Uh oh!

Add Faudio verb #804

Add Faudio verb #804

Uh oh!

Conversation

ImperatorS79 commented Jan 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

qparis Jan 12, 2019

Choose a reason for hiding this comment

Uh oh!

ImperatorS79 Jan 12, 2019

Choose a reason for hiding this comment

Uh oh!

Zemogiter commented Jan 14, 2019

Uh oh!

ImperatorS79 commented Jan 14, 2019

Uh oh!

Zemogiter commented Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ImperatorS79 commented Jan 20, 2019

Uh oh!

Zemogiter commented Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ImperatorS79 commented Jan 21, 2019

Uh oh!

Uh oh!

Zemogiter commented Jan 21, 2019

Uh oh!

ImperatorS79 commented Jan 23, 2019

Uh oh!

plata Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ImperatorS79 commented Jan 12, 2019 •

edited

Loading

Zemogiter commented Jan 14, 2019 •

edited

Loading

Zemogiter commented Jan 21, 2019 •

edited

Loading