Skip to content

Commit

Permalink
Improve Daemon CI (#48)
Browse files Browse the repository at this point in the history
* test: fix changed process execution

* test: upgrade phpunit

* test: implement mess detector and code sniffer

* ci: upgrade ci workflows

* ci: use pcntl

* ci: php 8.1 compatibility
  • Loading branch information
g105b authored May 8, 2024
1 parent 4732e17 commit 3bbdf3e
Show file tree
Hide file tree
Showing 12 changed files with 1,649 additions and 386 deletions.
138 changes: 124 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,56 +5,102 @@ on: [push]
jobs:
composer:
runs-on: ubuntu-latest
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache Composer dependencies
uses: actions/cache@v3
with:
path: /tmp/composer-cache
key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
key: ${{ runner.os }}-${{ matrix.php }}-${{ hashFiles('**/composer.lock') }}

- uses: php-actions/composer@v6
- name: Composer install
uses: php-actions/composer@v6
with:
php_version: ${{ matrix.php }}
php_extensions: pcntl

- name: Archive build
run: mkdir /tmp/github-actions/ && tar -cvf /tmp/github-actions/build.tar ./

- name: Upload build archive for test runners
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

phpunit:
runs-on: ubuntu-latest
needs: [composer]
needs: [ composer ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

outputs:
coverage: ${{ steps.store-coverage.outputs.coverage_text }}

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Unit tests
uses: php-actions/phpunit@v3
env:
XDEBUG_MODE: cover
with:
php_version: 8.1
version: 10
php_version: ${{ matrix.php }}
php_extensions: xdebug pcntl
configuration: test/phpunit/phpunit.xml
bootstrap: vendor/autoload.php
coverage_text: _coverage/coverage.txt
coverage_clover: _coverage/clover.xml

- name: Store coverage data
uses: actions/upload-artifact@v4
with:
name: code-coverage-${{ matrix.php }}-${{ github.run_number }}
path: _coverage

coverage:
runs-on: ubuntu-latest
needs: [ phpunit ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

steps:
- uses: actions/download-artifact@v4
with:
name: code-coverage-${{ matrix.php }}-${{ github.run_number }}
path: _coverage

- name: Output coverage
run: cat "_coverage/coverage.txt"

- name: Upload to Codecov
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}

phpstan:
runs-on: ubuntu-latest
needs: [composer]
needs: [ composer ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
Expand All @@ -63,4 +109,68 @@ jobs:
- name: PHP Static Analysis
uses: php-actions/phpstan@v3
with:
php_version: ${{ matrix.php }}
path: src/
level: 6

phpmd:
runs-on: ubuntu-latest
needs: [ composer ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

steps:
- uses: actions/download-artifact@v4
with:
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Mess Detector
uses: php-actions/phpmd@v1
with:
php_version: ${{ matrix.php }}
path: src/
output: text
ruleset: phpmd.xml

phpcs:
runs-on: ubuntu-latest
needs: [ composer ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3 ]

steps:
- uses: actions/download-artifact@v4
with:
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Code Sniffer
uses: php-actions/phpcs@v1
with:
php_version: ${{ matrix.php }}
path: src/
standard: phpcs.xml

remove_old_artifacts:
runs-on: ubuntu-latest

steps:
- name: Remove old artifacts for prior workflow runs on this repository
env:
GH_TOKEN: ${{ github.token }}
run: |
gh api "/repos/${{ github.repository }}/actions/artifacts?name=build-artifact" | jq ".artifacts[] | select(.name | startswith(\"build-artifact\")) | .id" > artifact-id-list.txt
while read id
do
echo -n "Deleting artifact ID $id ... "
gh api --method DELETE /repos/${{ github.repository }}/actions/artifacts/$id && echo "Done"
done <artifact-id-list.txt
8 changes: 5 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
"description": "Background script execution with cross-platform compatible streaming.",

"require": {
"php": ">=7.4",
"php": ">=8.1",
"ext-pcntl": "*"
},
"require-dev": {
"phpstan/phpstan": "^v1.8",
"phpunit/phpunit": "^v9.5"
"phpstan/phpstan": "^v1.10",
"phpunit/phpunit": "^10.5",
"phpmd/phpmd": "^2.13",
"squizlabs/php_codesniffer": "^3.7"
},

"autoload": {
Expand Down
Loading

0 comments on commit 3bbdf3e

Please sign in to comment.