Skip to content

Conversation

@BejoIjo
Copy link
Contributor

@BejoIjo BejoIjo commented Dec 9, 2017

Improvements includes:

  • All the improvements from previous PR
  • Replaced SQLite with LiteDB (for more lightweight and stable)
  • Randomly generated citation history based on citation counts
  • Randomly generated past arrest reports if ped wanted (with probability)
  • Replace ComputerPedView implementation to make it more stable
  • Made several fixes on Form components and layout adjustments

@ainesophaur
Copy link
Collaborator

Since this is your active branch I'll make my suggestions here.

One thing to add is the config file addition for enabling/disabling randomly generated citations and arrests. While 90% of the players will certainly appreciate it, there are some that wont. Put in an option in the config class and set a default by code. Optionally, add an in game prompt/warning if they are missing the config value (just so we dont get tons of support requests/complaints on how to change it)

Im pulling this branch down for testing. Is it stable enough for me to test now or do you have pending/uncommitted work?

@BejoIjo
Copy link
Contributor Author

BejoIjo commented Dec 9, 2017

Yes, this is the latest one. you may test it.
BTW. you will only need to put LiteDB.dll in the main GTA V folder to make it works. (no need for any interop library)

Regarding configuration for randomly generated arrest report & citation, that's a good Idea. I'll add it early on tomorrow.

@BejoIjo
Copy link
Contributor Author

BejoIjo commented Dec 9, 2017

here you go, the latest commit with configuration flag to disable/enable random historical Arrest Reports and Traffic citations.

@smithrn99
Copy link

Copied from forum:

Great update! However, I noticed two bugs.

  1. The DoB bug (missing zeroes) is still present. "1/4/1997" should correct to "01/04/1997" etc to prevent errors when writing citations/arrest reports.
  2. The randomized citations all show a SHERIFF2 as the vehicle.

@BejoIjo
Copy link
Contributor Author

BejoIjo commented Dec 12, 2017

i pushed the potential fix. please try it out when the author release it.

@BejoIjo
Copy link
Contributor Author

BejoIjo commented Dec 21, 2017

I guess that's it for now and the next release. Everything should be good (y)

@BejoIjo
Copy link
Contributor Author

BejoIjo commented Dec 26, 2017

Ready for release. Engage!

@ainesophaur
Copy link
Collaborator

I'll pull it, build and release it tomorrow.

@ainesophaur ainesophaur merged commit cd5ab0f into piergud:master Dec 27, 2017
@ainesophaur
Copy link
Collaborator

Released to LSPDFR

piergud pushed a commit that referenced this pull request Apr 11, 2018
Various Improvements by BejoIjo (Dec 8 2017)
piergud pushed a commit that referenced this pull request Aug 18, 2024
Various Improvements by BejoIjo (Dec 8 2017)
piergud pushed a commit that referenced this pull request Aug 18, 2024
Various Improvements by BejoIjo (Dec 8 2017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants