-
Notifications
You must be signed in to change notification settings - Fork 5.5k
IMAP - new-email source bug fix #18616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughBumps IMAP package version and dependencies; changes IMAP New Email source to skip staleness checks and historical processing when the mailbox has no messages. Adds trailing-newline formatting to two app files. No API signatures changed except the version field. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as Workflow Runtime
participant Src as IMAP New Email Source
participant IMAP as IMAP Server
User->>Src: Run source
Src->>IMAP: Connect & open mailbox
IMAP-->>Src: box (messages.total, uidnext, etc.)
alt messages.total is falsy (0/undefined)
note over Src: Skip staleness check and historical fetch
Src-->>User: Exit / no events emitted
else messages.total is truthy
note over Src: Proceed with guarded checks
Src->>Src: hasNewMessages(box): check box.messages.total && staleness
opt Historical backfill (if configured)
Src->>IMAP: Fetch historical messages
IMAP-->>Src: Message list
Src-->>User: Emit historical events
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
/approve |
Resolves #18604
Summary by CodeRabbit
Bug Fixes
Chores