Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Surface/Poisson4] Always update counter and prevent overflow access in poisson4 octree #4316

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

shauidu
Copy link
Contributor

@shauidu shauidu commented Aug 11, 2020

"cnt++" will not be executed in some conditions

@kunaltyagi
Copy link
Member

some conditions

An example please

@kunaltyagi kunaltyagi added module: surface needs: author reply Specify why not closed/merged yet labels Aug 12, 2020
@shauidu
Copy link
Contributor Author

shauidu commented Aug 12, 2020

some conditions

An example please

At line 821, there is a "if...continue" statement

@kunaltyagi kunaltyagi changed the title avoid dead loop [Poisson4] prevent overflow access in poisson4 octree impl (third_party code bugfix) Aug 12, 2020
@kunaltyagi kunaltyagi removed the needs: author reply Specify why not closed/merged yet label Aug 12, 2020
@kunaltyagi kunaltyagi added the changelog: fix Meta-information for changelog generation label Sep 7, 2020
@kunaltyagi kunaltyagi changed the title [Poisson4] prevent overflow access in poisson4 octree impl (third_party code bugfix) [Surface/Poisson4] Always update counter and prevent overflow access in poisson4 octree Sep 7, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.12.0 milestone Sep 7, 2020
@kunaltyagi kunaltyagi merged commit b9d9f56 into PointCloudLibrary:master Sep 7, 2020
kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Sep 12, 2020
…point_field_types

* origin/new_point_field_types: (211 commits)
  [CI] Make windows build on c:\ drive to fix out-of-disk-space errors (PointCloudLibrary#4382)
  Replace '.points.' with just '.' (PointCloudLibrary#4217)
  [Surface/Poisson4] Always update counter and prevent overflow access in poisson4 octree (PointCloudLibrary#4316)
  [surface/3rdParty] Add stdlib header for malloc in poisson (bugfix for gcc-5) (PointCloudLibrary#4376)
  [Misc] Deprecate unused ease-of-internal-use headers (PointCloudLibrary#4367)
  Use nth_element in median filter nth_element is faster than partial_sort, and should be used for median finding
  enable CUDA on 16.04 CI
  Optimize includes As recommended by include-what-you-use
  Update gpu_install.rst
  Fix getColor()
  Variable needs to be expanded.
  Optimize includes As recommended by include-what-you-use
  [gpu] Add square distances to ApproxNearestSearch (PointCloudLibrary#4340)
  [common] Allow conversion of PointCloud with more than 32-bit size rows/columns (PointCloudLibrary#4343)
  Change the macro to detect and remove deprecations before release
  update docstring
  clang format approx_nsearch.cu
  another indentation fix
  fix indentation and getBitsNum function
  Allow file_io to read large point clouds depending on PCL config (PointCloudLibrary#4331)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: surface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants