Corrige filtro de interprete por data e horario disponivel #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icar agendamentos
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the interpreter filtering by date and time to properly verify if there are conflicting appointments during the requested time slot. The filtering now returns only interpreters who have a schedule for the requested time (according to the Schedule table) and don't have any confirmed appointments during that time (according to the Appointment table).
- Refactored the InterpreterSpecification to properly validate appointment conflicts
- Simplified the InterpreterService to consolidate date/time handling
- Added comprehensive integration tests using Testcontainers with PostgreSQL
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| InterpreterSpecification.java | Completely refactored filtering logic to properly check appointment conflicts with new subquery approach |
| InterpreterService.java | Simplified date/time parameter handling by consolidating into a single LocalDateTime parameter |
| InterpreterSpecificationIntegrationTest.java | Added comprehensive integration tests using Testcontainers to validate filtering behavior |
| InterpreterSpecificationTest.java | Removed unit tests (replaced by integration tests) |
| application-testcontainers.properties | Added Testcontainers configuration for PostgreSQL-based integration tests |
| pom.xml | Added Testcontainers dependencies for PostgreSQL integration testing |
...a/com/pointtils/pointtils/src/infrastructure/repositories/spec/InterpreterSpecification.java
Show resolved
Hide resolved
...a/com/pointtils/pointtils/src/infrastructure/repositories/spec/InterpreterSpecification.java
Show resolved
Hide resolved
...a/com/pointtils/pointtils/src/infrastructure/repositories/spec/InterpreterSpecification.java
Show resolved
Hide resolved
…ades do testcontainers via TestPropertySource
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Título
Corrige filtro de interprete por data e horario disponivel para verificar se existem agendamentos no horário
📌 Descrição
Corrige filtro de intérprete por data e horário disponível para verificar se existem agendamentos no horário. Serão retornados apenas os intérpretes que atenderem no horário informado (de acordo com tabela Schedule) e que, além disso, não tenham um agendamento já confirmado para o horário informado (de acordo com tabela Appointment).
🛠️ O que foi feito?
🔍 Arquivos novos/modificados?
path:
pointtils/src/main/java/com/pointtils/pointtils/src/application/services/InterpreterService.javapath:
pointtils/src/main/java/com/pointtils/pointtils/src/infrastructure/repositories/spec/InterpreterSpecification.javapath:
pointtils/src/test/java/com/pointtils/pointtils/src/infrastructure/repositories/spec/InterpreterSpecificationIntegrationTest.java🧪 Testes realizados:
Valores no banco de dados:
Resultados do filtro - sem schedule para aquele horário:
Resultados do filtro - tem schedule para aquele horário e é antes de agendamento:
Resultados do filtro - tem schedule para aquele horário e é depois de agendamento:
Resultados do filtro - tem schedule para aquele horário mas horário informado iniciaria durante um agendamento:
Resultados do filtro - tem schedule para aquele horário mas horário informado encerraria durante um agendamento:
👀 Problemas conhecidos:
Ao executar os testes locais, está tudo funcionando corretamente!
No entanto, na pipeline do GitHub, está falhando.
✅ Checklist
📎 Referências
#129