Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBIF queries get converted (for some reason) #165

Closed
tpoisot opened this issue Apr 15, 2023 · 0 comments · Fixed by #166
Closed

GBIF queries get converted (for some reason) #165

tpoisot opened this issue Apr 15, 2023 · 0 comments · Fixed by #166
Labels
bug Something isn't working component:GBIF effort:low priority:medium

Comments

@tpoisot
Copy link
Member

tpoisot commented Apr 15, 2023

Using "hasCoordinate" => true as a query will result in this being interpeted as "hasCoordinate" => 1. The fix will probably involve making sure that everything is a string before being passed to HTTP for the request.
tpoisot added a commit that referenced this issue Apr 15, 2023
@tpoisot
🐛add tests to capture #165
74862a2
@tpoisot tpoisot mentioned this issue Apr 15, 2023
Merged
tpoisot added a commit that referenced this issue Apr 16, 2023
@tpoisot
✅ the tests are passing
5c42bb6 
Closes #165
tpoisot added a commit that referenced this issue Apr 16, 2023
@tpoisot
Fix the GBIF issue for single argument queries (#166)
ce74a0a 
* 🐛add tests to capture #165

* update README

* ✅ fix a bug due to GBIF re-adding a formerly missing occurrence

* ⚠️  add error when the value is not part of the enum key

* 🐛 update the imported modules for edgecase test

* ℹ️ add a temporary log to see the query string

* ✅ the tests are passing

Closes #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:GBIF effort:low priority:medium
Projects
Species Distribution Toolkit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the GBIF issue for single argument queries PoisotLab/SpeciesDistributionToolkit.jl
1 participant
@tpoisot