Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺️ Update plotting code to work with Makie as a default #105

Merged
merged 25 commits into from
Feb 7, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Dec 17, 2022

Fixes #104

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Base: 44.72% // Head: 40.60% // Decreases project coverage by -4.13% ⚠️

Coverage data is based on head (2b8e7ce) compared to base (6c68fd9).
Patch coverage: 2.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   44.72%   40.60%   -4.13%     
==========================================
  Files          47       35      -12     
  Lines        1563     1133     -430     
==========================================
- Hits          699      460     -239     
+ Misses        864      673     -191     
Flag Coverage Δ
unittests 40.60% <2.38%> (-4.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SimpleSDMLayers/src/operations/mosaic.jl 96.55% <ø> (ø)
SimpleSDMLayers/src/operations/rescale.jl 35.71% <0.00%> (-21.98%) ⬇️
src/integrations/gbif_layers.jl 0.00% <0.00%> (ø)
src/integrations/makie.jl 0.00% <0.00%> (ø)
SimpleSDMLayers/src/interfaces/broadcast.jl 20.45% <10.00%> (ø)
SimpleSDMLayers/src/lib/overloads.jl 72.27% <0.00%> (-3.97%) ⬇️
SimpleSDMLayers/src/interfaces/iteration.jl 34.37% <0.00%> (-3.13%) ⬇️
recipes.jl
...impleSDMDatasets/src/providers/CHELSA/chelsa_v1.jl
...mpleSDMDatasets/src/providers/EarthEnv/earthenv.jl
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot marked this pull request as draft December 19, 2022 03:08
@tpoisot tpoisot marked this pull request as ready for review February 3, 2023 15:28
@tpoisot tpoisot merged commit 3d1fb4c into main Feb 7, 2023
@tpoisot tpoisot deleted the tpoisot/issue104 branch February 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plotting code to work with Makie as a default
2 participants