-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 correct check on layer inner type #146
Conversation
Documentation for this PR at https://poisotlab.github.io/SpeciesDistributionToolkit.jl/previews/PR146/ |
@gottacatchenall use this branch to test and report back? I'll write an additional test to download/save/read a worldclim layer, or something like this |
Currently throwing this This is the line that fails
as its trying to convert |
Codecov ReportBase: 41.01% // Head: 48.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 41.01% 48.81% +7.80%
==========================================
Files 35 46 +11
Lines 1141 1438 +297
==========================================
+ Hits 468 702 +234
- Misses 673 736 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Got it. I'll write the test this evening, it shouldn't be a hard fix. |
This should do the trick, as soon as it passes I'll tag a new patch release and you'll be good to go, @gottacatchenall |
can confirm this fixes the error here |
Closes #145