Error with eslint no-unresolved since 6.2.0

[tofumatt]

See the error here: https://travis-ci.org/mozilla/addons-frontend/jobs/252183587#L1977

Since 6.2.0 I get the following error when running eslint against my repo (addons-frontend): Unable to resolve path to module 'react-onclickoutside' import/no-unresolved

This happens for 6.3.x as well. Not sure what caused it but it isn't happening elsewhere, wondering if there was a recent refactor/change of file structure that would've caused it.

[Pomax]

that's very odd, as 6.3 should have been a rollback to 6.1... let me try to re-rollback O_o

[Pomax]

@Andarist any idea?

[Pomax]

I've published 6.4, which should be a reversion to 6.1.1 - let me know if that's fixed things @tofumatt

[tofumatt]

Passed all my tests. Thanks!

[Andarist]

@Pomax @tofumatt
That is turbo strange o.O @tofumatt would u be able to provide a repository with reproduced issue? Would be helpful for debugging purposes.

[tofumatt]

Indeed, the repo is addons-frontend. Here are the relevant failing PRs:

• Update react-onclickoutside to the latest version 🚀 mozilla/addons-frontend#2731 (6.2.0, possibly unrelated)
• fix(package): update react-onclickoutside to version 6.3.0 mozilla/addons-frontend#2732 (6.3.0)
• fix(package): update react-onclickoutside to version 6.3.1 mozilla/addons-frontend#2733 (6.3.1)

It passed again for 6.4.0: mozilla/addons-frontend#2741

[Andarist]

Thanks, gonna set it up in a minute !

[Andarist]

Ok, I know what happened. es directory was not published on those versions, and the resolver (rightfully) tried to access it (as specified in package.json's module entry).

@Pomax prepublish script should be added to ensure valid publications, although according to
https://docs.npmjs.com/misc/scripts

prepare: Run both BEFORE the package is packed and published, and on local npm install without any arguments (See below). This is run AFTER prepublish, but BEFORE prepublishOnly.

and we have prepare set up in place already and it works correctly for me for this use case. What version of npm are you on?

[Pomax]

@Andarist whatever was the latest node 7.x with npm 3.x - I updated it since due to the Nodejs security advisory since, so maybe npm3 was too low and it needed 4 or 5?

edit looking through the changelog, prepare did not exist until npm4, so that's probably it.

[Andarist]

Hm, aint sure how to properly maintain scripts for various version of npm. there might not be any, but as only u have publishing rights and u have updated ur node and npm (from what I understand) - this shouldnt happen anymore.

Anyway - republishing what got reverted should be made I think.

[Pomax]

We should probably add an engines section to the package.json like { "engines" : { "npm" : ">=4" } } so that running it with npm3 will be flagged as unsupported

[Pomax]

@Andarist want to file a new PR with the changes on top of 6.4? I can then publish it with node 8/npm5 which should work.