Skip to content

Loopr 1.15 — the crash that was closing your popups

Choose a tag to compare

@PortableDiag PortableDiag released this 13 Sep 17:07
· 10 commits to main since this release

Fixed the crash that took Loopr down — and every floating window with it.

Tapping ⏪, or double-tapping the left of the screen, in the first ten seconds of a video crashed the whole app whenever the player hadn't worked out that video's length yet. Rewinding ten seconds from three seconds in asks for a negative position, and the check meant to keep the position in range couldn't cope with one.

Loopr is a single app process, so the floating windows live in it too: one bad tap in the full-screen player closed every window you had open, instantly and without a word. That is why the popups looked like they were dying on their own.

Found in the phone's own crash log rather than guessed at:

java.lang.IllegalArgumentException: Cannot coerce value to an empty range:
maximum -6424 is less than minimum 0.

A video's length is now picked up whenever the player works it out, not only at the single instant playback starts. When the two didn't line up, Loopr treated that video as having no length for as long as it played — a seek bar stuck at zero, a running time stuck at 0:00, no A–B markers, and the rewind crash above armed for the whole video instead of for a fraction of a second.

Covered by tests that include the expression that shipped in 1.14, asserting it still throws on the exact value from the crash. 15 instrumented tests pass on API 35.