Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint - May 13 to May 24, 2024 #22184

Closed
benjackwhite opened this issue May 8, 2024 · 6 comments
Closed

Sprint - May 13 to May 24, 2024 #22184

benjackwhite opened this issue May 8, 2024 · 6 comments
Labels
sprint Sprint planning

Comments

@benjackwhite
Copy link
Contributor

benjackwhite commented May 8, 2024

Global Sprint Planning

3 things that might take us down

  1. Clickhouse fire rages

Team sprint planning

For your team sprint planning copy this template into a comment below for each team.

# Team ___

**Support hero:** ___

## Retro

<!-- Grab the high and low priority items from last time and add whether that item was completed or not -->

- 

## Hang over items from previous sprint

<!-- For each item, decide to re-prioritise (and add below) or deprioritise -->

- Item 1. prioritised/deprioritise

## OKR

1. OKR, status (red/yellow/green) and action points if yellow/red


### High priority

-

### Low priority / side quests

-

@benjackwhite benjackwhite added the sprint Sprint planning label May 8, 2024
@benjackwhite benjackwhite pinned this issue May 8, 2024
@benjackwhite
Copy link
Contributor Author

benjackwhite commented May 8, 2024

Team Benterprise what-the-heck-is-siem Infra

Hang over items from previous sprint

  1. 🟡 SOC2 Audit work came in with a fair amount of follow up work taking a good chunk of @danielxnj
  2. 🟡 Switched gear to try Loki as our central log system to tick the SIEM box @danielxnj
  • Still a lot of work here to make it performant, get all the logs from different systems in etc.
  1. 🟢 Noticed big costs in Cloudwatch logs - investigated where it was coming from and dropped the issuse (halving the cost) @frankh

  2. 🟢 Get Vault UI and roles and accounts setup @danielxnj

  • We will let this take a back seat to focus on other things atm
  1. 🟢 New kafka setup (i.e. correct zones and size for migrating over to) @danielxnj
  2. 🔴 Get some or all logs running into SIEM tool @danielxnj
  • Ditched Wazuh as it seemed like a maintenance nightmare
  1. 🔴 Documentation for Canary deploys so that people can use them @frankh
  2. 🟢 Capacity planning dashboard with additional alerting @frankh
  3. 🟢 Verify and then document / publicize the IP allow list stuff @benjackwhite
  4. 🟢 Rollout security improvement fixes @benjackwhite
  5. 🟡 CDP v1.5 - Webhooks destination filtered by Action @benjackwhite

OKR

  1. 💪 Deploy with confidence 🟢
  • Finalize our Canary Deploy process 🟡
  1. 🚨 Improved alerting and monitoring 🟢
  • SIEM work has made this a priority
  1. 🔒 Deeper Security 🟡
  2. 💰 Continued cost control 🟢

High priority

  1. Look into Loki performance as we will base our SIEM plan on it @frankh
  2. Get as many other log sources into Loki as possible (Kubernetes audit logs, Cloudtrail, SQL/Clickhouse queries, Metabase, HogQL queries) @danielxnj
  3. Get more useful auditing logs out of Django (auth attempts, access logs, HogQL queries) @benjackwhite
  4. Get Metabase setup to tick the audit boxes (auditing, SSO etc.) @frankh @danielxnj
  5. Continue with Soc2 Audit follow up @danielxnj
  6. Fix all remaining High/medium pen test outcomes @benjackwhite
  7. Offsite!

@EDsCODE
Copy link
Member

EDsCODE commented May 8, 2024

Team Data Shack

OKR Q2 2024

Objective

Release data warehouse to everyone

  • Key Results:
    • Integration first experience
      • schemas are reliable
      • modeling of each integration is clear
      • Good automatic roll up views and joins
      • Wizard to onboard people
    • Establish a solid pattern to build integrations
    • Complete data warehouse experience in the rest of the app (insights, feature flags, experiments)

James as a Service -> Clickhouse as a Service

  • Key Results:
    • Better Visibility
      • Regularly testing backups
      • Monitoring/alerting
      • Mutations
      • Moves
    • Management
      • Managing/killing mutations
    • Self Serve
      • Schema design feedback (James non blocking
      • Schema management
    • Automation
      • Replace/Upgrade replicas
      • Upgrading to 24.04
      • Disk configs

Retro

Product

  • @EDsCODE Postgres integration all connection options. Spike of customer requests that really want this working. Solved the immediate bugs here. Did not end up building out connection options.
  • @EDsCODE ^shifted focus to resolving issues with joined person property filtering
  • @Gilbert09 Schema Validation workflow. Ability to edit schema that's interpreted by clickhouse

Infra

  • Fix data discrepancies (blocking upgrade to 23.12)
  • Fully upgrade CH clusters to 23.12
  • Storage increases across the clusters
  • EU Cluster replacement progress (node is up - waiting to start replication)

High priority

  • offsite

Product

  • making the UI changes to move sources into pipeline 3000
  • Hackathon

Infra

  • Hackathon
  • Start EU replication
  • Upgrade EU Cluster to 23.12
  • Increase storage on EU instances

@mariusandra
Copy link
Collaborator

mariusandra commented May 8, 2024

Team Product your Analytics

Support hero: Thomas

Retro

We're still in the middle of it all. HogQL insights are out for everyone. We found a few blind spots (formula + differing results for breakdown options, MAU trends modal, dashboard issues), which we're hard at work on. Dashboards are getting better by the day, fixed a big insight issue today.

  • 🟢 100% of all insight results for everyone use the new HogQL backend @mariusandra

    • 🟡 Clean up insights - everyone
    • 🟡 Fix existing insight bugs - everyone
    • 🟡 Fix dashboardLogic @webjunkie
    • ⚪ Convert filters to query for the /api/../insight endpoints
    • ⚪ Remove all old legacy code @thmsobrmlr
  • Low priority / side quests

    • 🟡 Start developing the new insight features (Sandy joined and worked on this!)
    • ⚪ Fix shared dashboards reloads @Twixes
    • ⚪ Project environments

Hang over items from previous sprint

Support & insight bugs.

OKR

No major change here.

  • HogQL-based querying

    • Convert the remaining legacy queries to HogQL and release to public (Thomas, Julian, Marius)
      • 🟢 Insights – they are rolled out!! (still some bugs)
      • ⚪ Cohorts
    • Remove legacy querying backend (Thomas, Julian)
      • 🟠 Clean up or rewrite dashboardLogic 👈 this sprint
      • 🟠 Convert filters to query (insights, notebooks, activity log, experiments) 👈 this sprint
    • Missing Product Analytics features (Thomas, Julian)
      • ⚪ Breakdowns (multiple) in literally everything
      • 🟠 Make a list based on GitHub issues from customer requests… 👈 this sprint
      • ⚪ Fix those issues
    • Missing HogQL features (Tom, Marius)
      • 🟠 Type system, JSON 👈 Data Warehouse is on this
      • ⚪ Missing things when building funnels
  • Querying and processing performance (Thomas, Julian)

    • Global performance overview dashboards
      • ⚪ Insights
      • ⚪ Exports
      • ⚪ Cohort recalculations
    • Query request tracing
      • ⚪ Possibly query runner Python optimizations
      • ⚪ Exports improvements
    • ⚪ Identify top 5 query optimizations in terms of impact
  • Artificial Hog / Post Intelligence (Michael)

    • ⚪ Ask a question to get a magical insight (aware of your taxonomy)
    • ⚪ Figure out infra for upgrading queries and models
    • ⚪ Product-wide framework for opting into sharing with OpenAI
  • Activation (side quest: Michael)

    • ⚪ Michael to work with Growth to identify optimizations to getting started with Product Analytics

High priority

For most of the team:

  • 1 week offsite

For everyone else:

Low priority / side quests

Better tracked here: PostHog/meta#200

  • Project environments

@raquelmsmith
Copy link
Member

Team Growth

Retro

Retro items

High priority

  • @raquelmsmith
    • Out 1.5 days this sprint
    • UI for person profiles addon
    • General project management & comms for person profiles addon
    • Feature gating for activity panel
      • Migrate customers
    • Feature gating for automatic provisioning
      • Migrate customers
  • @xrdt
    • Put tasks into celery
      • Put sync_invoices tasks into celery so we can unlock parallelization and process isolation
      • Now have grafana metrics
    • Billing admin improvements
      • Make plans_map json a series of selects so it's less error-prone
      • Find a way to enhance history messages for inlined objects (CustomerToStripeCustomer relation)
    • compare_prices improvements
      • Add tests, make sure things like compare prices when we are overriding price_id_overrides works.
  • @zlwaterfield
    • Get teams plan addon shipped
    • New Teams Plan in app Billing UI
    • Work through changes to subscribe to all products - billing page, pricing page, activation logic, pay gates, etc. - will do next week
    • Better loading states for activate/deactivate subscriptions
    • Help Frank get Frank Django 3.10 out w/ upgrade to nginx
    • (nice to have) Do some cleaning of the billing repo - looking at https://github.com/HackSoftware/Django-Styleguide and trying to make the logic a cleaner and easier to read / debug
      • Has first PR that pulls trust scores out into a service
    • (nice to have) Look into email subscription (this seems like an important topic to make sure we're staying compliant - https://posthog.slack.com/archives/C043VJ93L3B/p1713538664642819)

Q2 Goals

✅=finished 🟡=in progress 🔴=won't finish

  1. ⚪ Create a flow in product analytics onboarding to fill out a dashboard template using actions (Raquel)
  2. 🟡 Simplify our subscription flows (Zach, supported by Raquel)
  3. 🟡 Launch pricing changes (Bianca, Raquel)
    • 🟡 Personless events - will help us reach more customers at an affordable price
    • Data warehouse - it's becoming pretty useful, we should charge for it
    • Session replay - we can reduce costs to improve retention and reach more people

This sprint

  • Only have 3 non-offsite days this sprint!

High priority

  • @raquelmsmith
    • Get automatic provisioning feature gating out
    • Personless events pricing UI on posthog.com and pricing tables
  • @xrdt
    • Move remaining bits of sync_invoices to celery
    • Finish PRs for updating unsubscription flow with auto-payment of outstanding invoices
    • Testing compare_prices
    • Billing admin improvements - make plans_map a dropdown of selects, feature_override reason
  • @zlwaterfield
    • Finish the 6 project limit migration
    • Migrating all enterprise customers to free teams addon + documenting for CS
    • Looking into other revenue edge cases in reporting
    • Planning for subscribing to all products next week

@robbie-c
Copy link
Collaborator

robbie-c commented May 8, 2024

Team Web Analytics

Support hero: n/a

Retro

High priority

  • 🟢 get session property filters in web analytics rolled out and working for all queries on the page (if not finished this sprint)

Low priority

  • 🔴 Rolling out the session property filters for all queries, not just on web analytics
  • 🔴 Ploughing through small feature requests for web analytics

Rolled out web analytics (with Beta tag) to 100%, but I'm not happy with query performance. Based on a hunch, I did a spike of using UUIDv7s (casted to UInt128) for the session id, so far it looks like it's a significant speedup, around 87% on clickhouse cloud, but needs to be tested in a prod-like env. See WIP RFC

Hang over items from previous sprint

  • deprioritised behind perf work: Rolling out the session property filters for all queries, not just on web analytics

OKR

  1. Make querying fast enough for large customers
  2. Do personless events work where necessary (unknown amount of work)
  3. Iterate on customer feedback
  4. Product management work

High priority

  • finish this spike on uuidv7s
  • if it's worth doing
    • write the SQL for the new sessions table that uses is
    • write and run a proper backfill job
    • switch the hogql sessions table over to the new table
    • make sure docs / sdks make it clear enough that session_ids should be a UUIDv7
  • then roll out session properties elsewhere in the app
  • mop up personless events, TBD(mykonos) what this involves

@neilkakkar
Copy link
Collaborator

neilkakkar commented May 8, 2024

Team Feature Success

Support hero: @neilkakkar
Days off:
Juraj: 5 + 3 days
Neil: 5 + 2 days

Retro

Hang over items from previous sprint


OKRs

  1. Make sure feature flags can handle 10x current scale
  2. Polish new experiments UI & collect feedback
  3. Add most requested surveys functionality

High priority

Stretch:

Low priority / side quests / maybe Neil will get to this next year

  • Temporal queues for feature success - @neilkakkar
  • Setup instrumentation for flip-flopping problem of experiment significance - @neilkakkar

@Twixes Twixes closed this as completed May 29, 2024
@Twixes Twixes unpinned this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint Sprint planning
Projects
None yet
Development

No branches or pull requests

7 participants