Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Action filtering for webhook apps #22056

Merged
merged 154 commits into from
May 28, 2024
Merged

feat: Action filtering for webhook apps #22056

merged 154 commits into from
May 28, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented May 3, 2024 •
edited

Problem

See #21721
and https://github.com/PostHog/product-internal/issues/599

Needs #22253

We want to replace the existing action webhooks with something a little more fit-for-purpose. To do this we need to:

  1. Support filtering plugins by actions as a config option on the plugin
  2. Allow webhook plugins to take care of templating the event into valid webhook content (e.g. for a slack webhook)

This PR attempts to solve problem 1

Changes

  • Refactors the ActionMatcher into the hub to be used by both webhook firing and composeWebhook processing
  • Moves reloading and pubsub into the ActionManager class as it feels more part of it.
  • Filters composeWebhoook plugins by the relevant action matcher if necessary
  • Adds option to the (legacy) UI behind a flag
  • Add tests for filtering logic
  • Ensure actions can not be deleted if they have connected plugins

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite
Refactoring action manager
bfd5e3d
@benjackwhite
Moved code around to potentially support filtering plugins by action …
beb5f35 
…matching
@benjackwhite
Changes
ed7b016
@benjackwhite
Changes
51655b4
@benjackwhite
comment
5ed3e5b
@benjackwhite
Merge branch 'master' into feat/actions-webhooks-v2
a927d17
@benjackwhite
Added migration
5b2ed4e
@benjackwhite
Started reworking it
41c7623
@benjackwhite
More changes
39a42f9
@benjackwhite
Fix up tests
c03d606
@benjackwhite
Fixed up action matching
301938e
@benjackwhite
Fixes
431ccb6
@benjackwhite
Added match action to plugin config api
7e7bb3c
@benjackwhite
Started adding action select
39658d8
@benjackwhite
Added api and UI for filtering by action
12f4a31
@benjackwhite
Fixes
b1a7d56
@benjackwhite
tidy
2e2f88c
@benjackwhite
Fixed flagging
f8796dd
@benjackwhite
Merge branch 'master' into feat/actions-webhooks-v2
1eb825c 
# Conflicts:
#	latest_migrations.manifest
@benjackwhite
Fix tests
58dc55a
@benjackwhite
Fixes
638f58b
@benjackwhite
Fix
21382bb
@benjackwhite
Fixes
128caa2
@benjackwhite
Fixes
53368ab
@benjackwhite
Added comment
e444701
@benjackwhite
Fixes
e13baa0
@benjackwhite
Fix test?
fb63170
@benjackwhite
Fixed migration
7c946e3
@benjackwhite
Fixes?
2474361
@benjackwhite
Fix tests
32de6b5
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite and others added 2 commits May 23, 2024 15:03
@benjackwhite
Merge branch 'master' into feat/actions-webhooks-part1
2f3cc68 
# Conflicts:
#	frontend/src/scenes/pipeline/pipelinePluginConfigurationLogic.tsx
#	posthog/api/test/__snapshots__/test_action.ambr
@github-actions
Update UI snapshots for chromium (1)
31fce23
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

12 snapshot changes in total. 0 added, 12 modified, 0 deleted:

  • chromium: 0 added, 12 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite and others added 4 commits May 28, 2024 08:35
@benjackwhite
Merge branch 'master' into feat/actions-webhooks-part1
ae4ae7c 
# Conflicts:
#	frontend/__snapshots__/scenes-other-settings--settings-session-timeout-password-only--dark.png
#	frontend/__snapshots__/scenes-other-settings--settings-session-timeout-password-only--light.png
@benjackwhite
Fix test
ac003ae
@benjackwhite
feat: Design updates for pipeline editing (#22389)
fba3769
@github-actions
Update UI snapshots for chromium (1)
dc29d04
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit c4fee6f into master May 28, 2024
86 checks passed
@benjackwhite benjackwhite deleted the feat/actions-webhooks-part1 branch May 28, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr left review comments

@tiina303 tiina303 tiina303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjackwhite @posthog-bot @tiina303 @thmsobrmlr