feat: Design updates for pipeline editing #22389

benjackwhite · 2024-05-21T15:32:16Z

Problem

Needs #22253
Needs #22056

The UI felt a little cluttered to me and was missing some QoL things.
Also the upcoming filters UI will take up the bottom left space so this is part of the longer term design goal.

Changes

Before	After

Adds boxes and padding to different sections
Makes the enable/disable a switch and more prominent
Add controls to the header
Adds beforeUnload logic

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

# Conflicts: # frontend/src/scenes/actions/Action.tsx # frontend/src/scenes/actions/actionEditLogic.tsx

posthog-bot · 2024-05-21T15:43:00Z

📸 UI snapshots have been updated

8 snapshot changes in total. 0 added, 8 modified, 0 deleted:

chromium: 0 added, 8 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

… into feat/compact-action-edit

github-actions · 2024-05-21T15:59:06Z

Size Change: +325 B (+0.03%)

Total Size: 1.03 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.03 MB	+325 B (+0.03%)

_{compressed-size-action}

posthog-bot · 2024-05-21T16:02:36Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts: # frontend/src/scenes/actions/actionEditLogic.tsx

posthog-bot · 2024-05-22T09:14:24Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-22T09:23:58Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

frontend/src/scenes/pipeline/PipelineBatchExportConfiguration.tsx

posthog-bot · 2024-05-23T14:16:00Z

📸 UI snapshots have been updated

12 snapshot changes in total. 0 added, 12 modified, 0 deleted:

chromium: 0 added, 12 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T15:06:44Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T15:17:02Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T15:30:15Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T15:40:50Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T15:51:01Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T16:01:17Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-23T16:11:50Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite and others added 21 commits May 10, 2024 16:58

Styles improvements

39d0878

Fix up wrapping

2df62f0

Fixes

9826a41

Fixes

3b33232

Refactor type

d027437

Fixes

db4cd3c

Fixes

13cfe32

Fixes

961c18f

Fix e2e

24f72e2

Update UI snapshots for chromium (1)

ece7a8f

Update UI snapshots for chromium (1)

9b46a01

Fix

87d7827

Added stories

4e305eb

Fix

69e3943

Update UI snapshots for chromium (1)

4ddd474

Fix

12053fe

Merge branch 'feat/actions-webhooks-part1' into feat/compact-action-edit

65dbeca

# Conflicts: # frontend/src/scenes/actions/Action.tsx # frontend/src/scenes/actions/actionEditLogic.tsx

Fixed up UI

1dcdcf0

Added buttons to header

af69e52

Fixes

9d99ff6

Fixes

bd2c8d9

benjackwhite marked this pull request as ready for review May 21, 2024 15:32

Update UI snapshots for chromium (1)

b6feb86

benjackwhite added 2 commits May 21, 2024 17:46

Fix spacing

b263377

Merge branch 'feat/compact-action-edit' of github.com:PostHog/posthog…

a9e9c1e

… into feat/compact-action-edit

Update UI snapshots for chromium (1)

4911a0a

Update UI snapshots for chromium (1)

4c13e81

benjackwhite changed the base branch from master to feat/actions-webhooks-part1 May 22, 2024 08:53

benjackwhite added 2 commits May 22, 2024 10:54

Merge branch 'feat/actions-webhooks-part1' into feat/compact-action-edit

764d8af

# Conflicts: # frontend/src/scenes/actions/actionEditLogic.tsx

Fixes

1d4a25b

benjackwhite requested a review from tiina303 May 22, 2024 08:56

Update UI snapshots for chromium (1)

707c6ae

Update UI snapshots for chromium (1)

a48add7

tiina303 approved these changes May 22, 2024

View reviewed changes

frontend/src/scenes/pipeline/PipelineBatchExportConfiguration.tsx Show resolved Hide resolved

benjackwhite and others added 2 commits May 23, 2024 15:05

Merge branch 'feat/actions-webhooks-part1' into feat/compact-action-edit

b13dd49

Update UI snapshots for chromium (1)

ee2884a

benjackwhite and others added 2 commits May 23, 2024 15:55

Merge branch 'feat/actions-webhooks-part1' into feat/compact-action-edit

6686285

Update UI snapshots for chromium (2)

b29c557

Update UI snapshots for chromium (2)

c3e865d

Update UI snapshots for chromium (2)

e4bc609

Update UI snapshots for chromium (2)

89aa3c8

Update UI snapshots for chromium (2)

7f60453

Update UI snapshots for chromium (2)

beabc13

Update UI snapshots for chromium (2)

59235cb

Fix

3dc0849

benjackwhite merged commit fba3769 into feat/actions-webhooks-part1 May 28, 2024
27 of 40 checks passed

benjackwhite deleted the feat/compact-action-edit branch May 28, 2024 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Design updates for pipeline editing #22389

feat: Design updates for pipeline editing #22389

benjackwhite commented May 21, 2024 •

edited

Loading

posthog-bot commented May 21, 2024

github-actions bot commented May 21, 2024 •

edited

Loading

posthog-bot commented May 21, 2024

posthog-bot commented May 22, 2024

posthog-bot commented May 22, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

posthog-bot commented May 23, 2024

feat: Design updates for pipeline editing #22389

feat: Design updates for pipeline editing #22389

Conversation

benjackwhite commented May 21, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

posthog-bot commented May 21, 2024

📸 UI snapshots have been updated

github-actions bot commented May 21, 2024 • edited Loading

posthog-bot commented May 21, 2024

📸 UI snapshots have been updated

posthog-bot commented May 22, 2024

📸 UI snapshots have been updated

posthog-bot commented May 22, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

benjackwhite commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading