Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HoloLens to list of PowerShell adopters #12940

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

reynoldsbd
Copy link
Contributor

Summary

Add information to ADOPTERS.md describing how PowerShell is used for Microsoft HoloLens development.

Checklist

@ghost ghost assigned iSazonov Jun 10, 2020
@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 11, 2020
ADOPTERS.md Outdated Show resolved Hide resolved
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs should not contain the locale as it's detected by the website. Also suggest calling out PS7 specifically since HoloLens dependency is specifically PS7+

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add the word HoloLens to our spelling dictionary right before this line: https://github.com/PowerShell/PowerShell/blob/master/.spelling#L336

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020
@SteveL-MSFT
Copy link
Member

CI failure is due to #12935 and isn't blocking for this PR.

@SteveL-MSFT
Copy link
Member

@iSazonov I think we're good to merge this one

@iSazonov
Copy link
Collaborator

@SteveL-MSFT I haven't permissions to force the merging. So waiting CI-macos resolving.

@SteveL-MSFT
Copy link
Member

@iSazonov ok, I rebased this branch and that should pass CI

@iSazonov iSazonov merged commit a3319d7 into PowerShell:master Jun 17, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 17, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants