-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fix typo in MapSecurityZone #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in MapSecurityZone #13921
Conversation
I could add xUnit tests for the code (in follow PR). |
I think test are definitely called for, given the potentially grave consequences of such a logic error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Logic fix
🎉 Handy links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine
PR Summary
Fix typo which comes from #11884 - "Internet" and "Intranet" names are too similar.
Discovered by @mklement0 #13869 (comment)
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.