Skip to content

Mark private members as static part 10 #14235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2020
Merged

Mark private members as static part 10 #14235

merged 2 commits into from
Nov 27, 2020

Conversation

xtqqczze
Copy link
Contributor

src\System.Management.Automation\
-src\System.Management.Automation\engine\

Contributes to #13897.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822

@xtqqczze
Mark private members as static part 10
336d903 
`src\System.Management.Automation\`
-`src\System.Management.Automation\engine\`

Contributes to PowerShell#13897.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
@ghost ghost assigned TravisEz13 Nov 23, 2020
@xtqqczze
Copy link
Contributor Author

CodeFactor "Complex Method" issues are preexisting.

@iSazonov
Copy link
Collaborator

@xtqqczze Please resolve merge conflicts.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 26, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 26, 2020 •
edited by unfurl-links bot
Loading

CI static fails on https://www.codefactor.io/

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 26, 2020 •
edited
Loading

CI static fails on https://www.codefactor.io/

HTTP Error 500.31 - Failed to load ASP.NET Core runtime

Tracking issue opened: #14269.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 26, 2020 •
edited by unfurl-links bot
Loading

CI static fails on https://www.codefactor.io/

HTTP Error 500.31 - Failed to load ASP.NET Core runtime

Tracking issue opened: #14269.

It works already :-)

Quality software, faster.

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 27, 2020
@iSazonov iSazonov merged commit 8d48693 into PowerShell:master Nov 27, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 27, 2020
@xtqqczze xtqqczze deleted the CA1822-p10 branch November 27, 2020 15:52
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @iSazonov @TravisEz13