Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for values in comparisons when comparing Enums #17654

Merged

Conversation

MartinGC94
Copy link
Contributor

PR Summary

Adds completion for scenarios like Get-VM | where State -eq <Tab> and Get-VM | where {$_.State -eq <Tab>}
This only works when the left side of the comparison is an enum.
Also, due to the bug mentioned here: #17653 it doesn't work when you explicitly specify the Property parameter like this: Get-VM | Where-Object -Property State -EQ you can work around this by either not specifying -Property or by explicitly specifying -Value

PR Context

PR Checklist

@ghost ghost assigned anmenaga Jul 9, 2022
@iSazonov iSazonov requested a review from daxian-dbw July 9, 2022 18:12
@ghost ghost added the Review - Needed The PR is being reviewed label Jul 17, 2022
@ghost
Copy link

ghost commented Jul 17, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

Hmm, looking that last commit I think about Roslin trivia. :-)

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 24, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 1, 2022
Co-authored-by: Ilya <darpa@yandex.ru>
@pull-request-quantifier-deprecated

This PR has 87 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +87 -0
Percentile : 34.8%

Total files changed: 3

Change summary by file extension:
.cs : +71 -0
.ps1 : +16 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw daxian-dbw merged commit 4051e09 into PowerShell:master Aug 22, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 22, 2022
@MartinGC94 MartinGC94 deleted the AddCompletionForValuesInComparisons branch August 23, 2022 16:07
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
@ghost
Copy link

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants