Skip to content

Webcmdlets display an error on https to http redirect #18595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 14, 2023
Merged

Webcmdlets display an error on https to http redirect #18595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
365557c
Detect insecure redirection
CarloToso Nov 17, 2022
b1f702c
Add error
CarloToso Nov 17, 2022
ba11ffe
Better error
CarloToso Nov 17, 2022
aa403e5
Fix error message
CarloToso Nov 17, 2022
2bb1cee
Reword Error
CarloToso Nov 17, 2022
5fb1a44
Merge branch 'PowerShell:master' into check-for-https-->http-redirect
CarloToso Nov 22, 2022
9ec8a57
Merge branch 'PowerShell:master' into check-for-https-->http-redirect
CarloToso Jan 9, 2023
3f33a24
WriteError -> ThrowTerminatingError
CarloToso Jan 9, 2023
972acf9
Merge branch 'PowerShell:master' into check-for-https-->http-redirect
CarloToso Jan 13, 2023
6ad7fc9
Update and add !AllowInsecureRedirect
CarloToso Jan 13, 2023
11d6ed9
fix tests
CarloToso Jan 13, 2023
38269a7
fix test error
CarloToso Jan 14, 2023
1508806
Merge branch 'master' into check-for-https-->http-redirect
CarloToso Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,15 @@ protected override void ProcessRecord()
// Disable writing to the OutFile.
OutFile = null;
}


// Detect insecure redirection
if (!AllowInsecureRedirect && response.RequestMessage.RequestUri.Scheme == "https" && response.Headers.Location?.Scheme == "http")
{
ErrorRecord er = new(new InvalidOperationException(), "InsecureRedirection", ErrorCategory.InvalidOperation, request);
er.ErrorDetails = new ErrorDetails(WebCmdletStrings.InsecureRedirection);
ThrowTerminatingError(er);
}

if (ShouldCheckHttpStatus && !_isSuccess)
{
string message = string.Format(
Expand Down
9 changes: 6 additions & 3 deletions src/Microsoft.PowerShell.Commands.Utility/resources/WebCmdletStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,15 @@
<data name="DuplicateKeysInJsonString" xml:space="preserve">
<value>Cannot convert the JSON string because a dictionary that was converted from the string contains the duplicated key '{0}'.</value>
</data>
<data name="KeysWithDifferentCasingInJsonString" xml:space="preserve">
<value>Cannot convert the JSON string because it contains keys with different casing. Please use the -AsHashTable switch instead. The key that was attempted to be added to the existing key '{0}' was '{1}'.</value>
</data>
<data name="IEDomNotSupported" xml:space="preserve">
<value>The response content cannot be parsed because the Internet Explorer engine is not available, or Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again. </value>
</data>
<data name="InsecureRedirection" xml:space="preserve">
<value>Cannot follow an insecure redirection by default. Reissue the command specifying the -AllowInsecureRedirect switch. </value>
</data>
<data name="KeysWithDifferentCasingInJsonString" xml:space="preserve">
<value>Cannot convert the JSON string because it contains keys with different casing. Please use the -AsHashTable switch instead. The key that was attempted to be added to the existing key '{0}' was '{1}'.</value>
</data>
<data name="MaximumRedirectionCountExceeded" xml:space="preserve">
<value>The maximum redirection count has been exceeded. To increase the number of redirections allowed, supply a higher value to the -MaximumRedirection parameter.</value>
</data>
Expand Down
4 changes: 2 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ Describe "Invoke-WebRequest tests" -Tags "Feature", "RequireAdminOnWindows" {
$command = "Invoke-WebRequest -Uri '$uri' -SkipCertificateCheck"

$result = ExecuteWebCommand -command $command
$result.Error.FullyQualifiedErrorId | Should -Be "WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand"
$result.Error.FullyQualifiedErrorId | Should -Be "InsecureRedirection,Microsoft.PowerShell.Commands.InvokeWebRequestCommand"
}
}

Expand Down Expand Up @@ -2732,7 +2732,7 @@ Describe "Invoke-RestMethod tests" -Tags "Feature", "RequireAdminOnWindows" {
$command = "Invoke-RestMethod -Uri '$uri' -SkipCertificateCheck"

$result = ExecuteWebCommand -command $command
$result.Error.FullyQualifiedErrorId | Should -Be "WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand"
$result.Error.FullyQualifiedErrorId | Should -Be "InsecureRedirection,Microsoft.PowerShell.Commands.InvokeRestMethodCommand"
}

#endregion Redirect tests
Expand Down