Skip to content

Conversation

CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Jan 27, 2023

PR Summary

Fix Bug: -OutputFile $null / -OutputFile '' cause -OutputFile to be ignored
FIx Bug: -InFile $null cause -InFile to be ignored

PR Context

Fix #19043

PR Checklist

@iSazonov
Copy link
Collaborator

@CarloToso Please fix tests.

@CarloToso
Copy link
Contributor Author

@iSazonov Tests fixed

@CarloToso CarloToso changed the title WebCmdlets -OutFile ValidateNotNullOrEmpty WebCmdlets -OutFile and -InFIle ValidateNotNullOrEmpty Jan 29, 2023
@CarloToso CarloToso changed the title WebCmdlets -OutFile and -InFIle ValidateNotNullOrEmpty WebCmdlets -OutFile and -InFile ValidateNotNullOrEmpty Jan 29, 2023
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 31, 2023
}

@{
Name = "Validate error for Invoke-RestMethod -InFile <null>"
Name = "Validate error for Invoke-RestMethod -InFile"
Copy link
Collaborator

@iSazonov iSazonov Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarloToso Please add one more negative test if InFile is Directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@iSazonov iSazonov closed this Jan 31, 2023
@iSazonov iSazonov reopened this Jan 31, 2023
@pull-request-quantifier-deprecated

This PR has 44 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +38 -6
Percentile : 17.6%

Total files changed: 2

Change summary by file extension:
.cs : +2 -0
.ps1 : +36 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Feb 1, 2023
@iSazonov iSazonov changed the title WebCmdlets -OutFile and -InFile ValidateNotNullOrEmpty Add ValidateNotNullOrEmpty to OutFile and InFile parameters of WebCmdlets Feb 1, 2023
@iSazonov iSazonov merged commit dd406b5 into PowerShell:master Feb 1, 2023
@CarloToso CarloToso deleted the webcmdlets-outfile-not-null-or-empty branch February 1, 2023 17:10
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-WebRequest -OutFile "" strange behaviour on windows
4 participants