-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add ValidateNotNullOrEmpty to OutFile and InFile parameters of WebCmdlets #19044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ValidateNotNullOrEmpty to OutFile and InFile parameters of WebCmdlets #19044
Conversation
@CarloToso Please fix tests. |
@iSazonov Tests fixed |
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
} | ||
|
||
@{ | ||
Name = "Validate error for Invoke-RestMethod -InFile <null>" | ||
Name = "Validate error for Invoke-RestMethod -InFile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarloToso Please add one more negative test if InFile is Directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
PR Summary
Fix Bug:
-OutputFile $null
/-OutputFile ''
cause -OutputFile to be ignoredFIx Bug:
-InFile $null
cause -InFile to be ignoredPR Context
Fix #19043
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).