-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect string to type conversion #19560
Fix incorrect string to type conversion #19560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix! Though @SeeminglyScience do you think it should error instead of returning null? I'm unsure what's more correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New suggestion of a test using the left-hand side operator (which should throw now like with other errors, and I don't if it will).
Co-authored-by: Andy Jordan <2226434+andschwa@users.noreply.github.com>
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess it needed braces 💁
Fix incorrect string to type conversion (PowerShell#19560)
🎉 Handy links: |
PR Summary
Fixes incorrect string to type conversions like:
[Type] 'int]whatever'
so they are no longer parsed as types.This was fixed by adding a check for
ScanType
to also check that the parsed type name matches the input type name.PR Context
Fixes #19559
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).