-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Group-Object
output using interpolated strings
#20745
Conversation
Fixes regression from PowerShell#20608 which mixed up use of `StringBuilder.AppendFormat` and interpolated strings, thereby passing the actual value to be formatted as the format string. Fixes PowerShell#20711.
@mawosoft Thanks! Please add test(s) to avoid future regressions. |
@microsoft-github-policy-service agree |
@iSazonov Test added. |
test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@SteveL-MSFT Maybe backport? |
Group-Object
output using interpolated strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
PR Summary
Fixes regression from #20608 which mixed up use of
StringBuilder.AppendFormat
and interpolated strings, thereby passing the actual value to be formatted as the format string.PR Context
Fixes #20711.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).