Skip to content

Corect xUnit heading and linting warnings #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

KevinMarquette
Copy link
Contributor

I noticed that the xUnit heading as rendered on GitHub was not displaying as a heading. I made some other whitespace adjustments to make my markdown linter happier while I was in there. It was looking for a return line around headings, lists, and code blocks.

@msftclas
Copy link

msftclas commented Mar 7, 2017

@KevinMarquette,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@iSazonov iSazonov added the Review - Needed The PR is being reviewed label Mar 7, 2017
@TravisEz13
Copy link
Member

cc @PowerShell/area-documentation

@TravisEz13
Copy link
Member

FYI, the DSC resources have a test to verify all markdown have these issues fixed. (I'd recommend disabling some of the rules like line length) Here: https://github.com/PowerShell/DscResource.Tests/blob/dev/Meta.Tests.ps1#L533

@TravisEz13
Copy link
Member

LGTM, changes are all lint issues and one minor fromatting due to lint issues.

@TravisEz13 TravisEz13 merged commit 302b520 into PowerShell:master Mar 8, 2017
@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants