Skip to content

New icon for PowerShell Core #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 3, 2017
Merged

New icon for PowerShell Core #4848

merged 8 commits into from
Oct 3, 2017

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Sep 16, 2017 •
edited
Loading

Fix #4676

Default color using familiar console icon, but with avatar (Posh-chan) colors

icon

@SteveL-MSFT SteveL-MSFT added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Sep 16, 2017
@SteveL-MSFT SteveL-MSFT changed the title Use PowerShell Avatar "Posh-chan" as new icon New icon for PowerShell Core Sep 27, 2017
@SteveL-MSFT
Copy link
Member Author

Vote here #4676 (comment)

@SteveL-MSFT
Copy link
Member Author

Latest change is to add some customer bitmaps to the installer:

installer
page2

@jpsnover
Copy link
Contributor

Looks great!

@iSazonov
Copy link
Collaborator

Can we make this woman's face beautiful? Only I think it skewed?

@SteveL-MSFT
Copy link
Member Author

@iSazonov are you referring to the "mouth"? that's the cursor of the prompt, sort of like >_

@iSazonov
Copy link
Collaborator

Yes, "mouth", "nose" - I'd preffer see a nice face. Can we make from >_ a purse? :-)

@SteveL-MSFT
Copy link
Member Author

@iSazonov I think it's too late to make changes to Posh-chan. It came from a pro designer and it's what we've been using in some marketing. I'm just reusing one of the original assets. Think of it more as "war paint" on her face ;P

@SteveL-MSFT
fixed launch powershell checkbox so it shows up more nicely as the …
ed97bb0 
…default checkbox

has a grey background

also reformatted the xml using a xml formatter to make it easier to read
@SteveL-MSFT
Copy link
Member Author

Last change is to fix the Launch PowerShell checkbox as the default control has a grey background which overlaps with the black icon. Now it looks like

launch

adityapatwardhan
adityapatwardhan approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment.

assets/Product.wxs Outdated
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">

<Wix
xmlns="http://schemas.microsoft.com/wix/2006/wi">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have accidentally hit Enter on that line. Will fix.

@DimaRazb
Copy link

She seems very aggressive, I don't like her very much. Designer could use a purse or raincoat I believe.

@joeyaiello
Copy link
Contributor

@SteveL-MSFT It's unclear to me which one is the default in this PR. Does it need to be updated to the black icon by default still?

Otherwise, LGTM. Love the new MSI look-and-feel.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Oct 2, 2017 •
edited
Loading

@joeyaiello default is:

blackicon

Can you approve if you're ok with this?

@SteveL-MSFT SteveL-MSFT added the Committee-Reviewed PS-Committee has reviewed this and made a decision label Oct 2, 2017
@SteveL-MSFT SteveL-MSFT removed the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Oct 2, 2017
@SteveL-MSFT
Copy link
Member Author

@PowerShell/powershell-committee reviewed this and fine with the changes

@adityapatwardhan
Copy link
Member

@joeyaiello Can you update your review?

joeyaiello
joeyaiello approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'm good

@adityapatwardhan adityapatwardhan merged commit ee902a6 into PowerShell:master Oct 3, 2017
@SteveL-MSFT SteveL-MSFT deleted the new-icon branch October 3, 2017 17:45
@bergmeister bergmeister mentioned this pull request Oct 4, 2017
Closed
@KingDarBoja KingDarBoja mentioned this pull request Sep 21, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@joeyaiello joeyaiello joeyaiello approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@adityapatwardhan adityapatwardhan

Labels
Committee-Reviewed PS-Committee has reviewed this and made a decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SteveL-MSFT @jpsnover @iSazonov @DimaRazb @joeyaiello @adityapatwardhan @msftclas @msftgits