Skip to content

[Ignore] Marketplace doesn't support SemVer, npm ONLY supports SemVer #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerLeonhardt
Copy link
Member

spoke to Aditya and Travis.... the plan we think is the best is:

do 2.0.0 as the version
Use the PATCH part of the version to rev betas

then the first stable version of 2 will be 2.1 so that it comes after 2.0.X

since npm only supports SemVer 2 and the marketplace only supports SemVer 1... the intersection is that is X.X.X so that's why we arrived at that

@rjmholt
Copy link
Contributor

rjmholt commented Jan 23, 2019

Move-Item : Cannot find path 'C:\projects\vscode-powershell\PowerShell-Preview-2.0.0-insiders-1032.vsix' because it

Somewhere a "preview" needs adding or removing?

@TylerLeonhardt
Copy link
Member Author

D'oh... fixed.

@TylerLeonhardt TylerLeonhardt merged commit 18ab27d into PowerShell:master Jan 23, 2019
@TylerLeonhardt TylerLeonhardt deleted the marketplace-doesnt-support-semver branch January 23, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants