Skip to content

[Ignore] Marketplace doesn't support SemVer, npm ONLY supports SemVer #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2019
Merged

[Ignore] Marketplace doesn't support SemVer, npm ONLY supports SemVer #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
158eec2
Marketplace doesn't support SemVer, npm ONLY supports SemVer
TylerLeonhardt Jan 23, 2019
b61a619
update doc
TylerLeonhardt Jan 23, 2019
a76b6ec
save new version to PackageJson
TylerLeonhardt Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ code --extensionDevelopmentPath="c:\path\to\vscode-powershell" .

To build a preview version of the extension, that is to say,
a version of the extension named "PowerShell Preview",
You can simply change the version in the package.json to include `-preview` at the end.
You can simply change the `name` in the package.json to include `-Preview` at the end.
When you build, this will:

- Add a warning to the top of the README.md to warn users not to have the stable and preview version enabled at the same time
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "PowerShell-Preview",
"displayName": "PowerShell Preview",
"version": "2.0.0-preview.1",
"version": "2.0.0",
"preview": true,
"publisher": "ms-vscode",
"description": "(Preview) Develop PowerShell scripts in Visual Studio Code!",
Expand Down
3 changes: 2 additions & 1 deletion vscode-powershell.build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ task GetExtensionData -Before Package {

if ($updateVersion) {
exec { & npm version $script:ExtensionVersion --no-git-tag-version --allow-same-version }
$script:PackageJson.version = $script:ExtensionVersion
}

$script:ExtensionName = $script:PackageJson.name
Expand Down Expand Up @@ -111,7 +112,7 @@ task Test Build, {
}
}

task CheckPreview -If { $script:ExtensionVersion -like "*preview*" } `
task CheckPreview -If { $script:ExtensionName -like "*Preview*" } `
UpdateReadme, UpdatePackageJson

task UpdateReadme {
Expand Down