Handle end-of-support PowerShell with error message #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can probably be improved, but at least it works! |
ghost
added
Area-Tech Debt
|
I'm still working on adding more actions, like actual actionable prompts, to our various possible reasons to fail at startup. Should help users a ton, I hope. |
Significantly improves our handling of PowerShell failing to start because it is unsupported.
andyleejordan
force-pushed
the
andschwa/end-of-support
branch
from
3559aed
to
676fe25
Compare
JustinGrote
reviewed
Apr 24, 2023
| if (satisfies(version, "<5.1.0")) { | ||
| void this.setSessionFailedGetPowerShell(`PowerShell ${version} is not supported, please update!`); | ||
| } else if (satisfies(version, ">=5.1.0 <6.0.0")) { | ||
| void this.setSessionFailedGetPowerShell("It looks like you're trying to use Windows PowerShell, which is supported on a best-effort basis. Can you try PowerShell 7?"); |
There was a problem hiding this comment.
Worth adding an aka.ms link to the install instructions here maybe?
There was a problem hiding this comment.
So with this.setSessionFailedGetPowerShell this actually now shows an error window popup with a button "Open PowerShell Install Documentation" that opens the link https://aka.ms/get-powershell-vscode!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves our handling of PowerShell failing to start because it is unsupported.
Resolves #4521.