Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB: added v5 support #3297

Merged

Conversation

airs0urce
Copy link
Contributor

@airs0urce airs0urce commented Jan 9, 2022

Added support for MongoDB 5 keywords

airs0urce added 9 commits Aug 13, 2020
…b-syntax-pull-request

# Conflicts:
#	components.js
#	components/prism-mongodb.js
#	components/prism-mongodb.min.js
#	plugins/autoloader/prism-autoloader.min.js
#	plugins/show-language/prism-show-language.min.js
#	tests/languages/mongodb/document_feature.test
@github-actions
Copy link

@github-actions github-actions bot commented Jan 9, 2022

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +46 B (+3.1%).

file master pull size diff % diff
components/prism-mongodb.min.js 1.47 KB 1.51 KB +46 B +3.1%

Generated by 🚫 dangerJS against 418ab44

@airs0urce airs0urce changed the title MongoDB: added v5 suport MongoDB: added v5 support Jan 9, 2022
@RunDevelopment RunDevelopment merged commit 8458c41 into PrismJS:master Jan 9, 2022
23 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jan 9, 2022

Thank you for contributing @airs0urce!

And for the future: Please don't spam PRs...

@airs0urce
Copy link
Contributor Author

@airs0urce airs0urce commented Jan 9, 2022

Thank you for contributing @airs0urce!

And for the future: Please don't spam PRs...

Thanks!

I was closing PRs after I see tests not passed. If there is way to check tests results before creating PR it would help me to check it before. But I'm not sure if this is possible now.

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jan 9, 2022

You can add as many commit as you want, even after creating a PR. The PR will be updated automatically after you push new commits. So if the tests fail, just keep adding commits until they pass.

way to check tests results

If you want to run tests locally, run npm run test. This will run our unit tests.
In your case, the lint failed. This test can be run using npm run lint.

Our CI also runs some additional tests, but the above two are the most important ones.

@airs0urce
Copy link
Contributor Author

@airs0urce airs0urce commented Jan 10, 2022

You can add as many commit as you want, even after creating a PR. The PR will be updated automatically after you push new commits. So if the tests fail, just keep adding commits until they pass.

way to check tests results

If you want to run tests locally, run npm run test. This will run our unit tests. In your case, the lint failed. This test can be run using npm run lint.

Our CI also runs some additional tests, but the above two are the most important ones.

Thank you for the info, will do like that next time. I send PRs not often on github, so didn't get used to the procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants