-
Notifications
You must be signed in to change notification settings - Fork 105
Added Table of Contents #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
easy for users to navigate to different sections. Documentation only PR, no builds affected
paramsiddharth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor changes needed for consistency. The rest looks good!
Co-authored-by: Param Siddharth <30315706+paramsiddharth@users.noreply.github.com>
Co-authored-by: Param Siddharth <30315706+paramsiddharth@users.noreply.github.com>
|
FWIW, GitHub automatically generates a Table of Contents for these if you just click on the upper-left menu button near the filename in the viewing panel: The beauty of GitHub's automatic solution is that it will never become out-of-date. ✨ With that in mind, do we still want to add this? It is undoubtedly more visible, so it's just a question of if that visibility outweighs the long-term maintenance burden. 🤷♂️ 🤔 |
Good point! As amazing as this feature is, I think we'd still go with considering this PR for this particular repository. "More visibility" isn't exactly going to be the criterion, but I think the design team intended on having this added to the README. Nevertheless, thank you for pointing out the fact that there's a button that automatically generates the ToC for us! It will now be helpful for me every time I navigate through GitHub repositories. 🤗 |
|
Forgot I was logged into my test account there. 😊 |
@JamesMGreene Haha, big reveal, James! 😁 Your test account just got a new follower~! Had I known it was you, I'll probably let you make the final decision instead of what was proposed in the bugbash. Sorry about that! |
|
I'm fine with the change! 👍🏻 |

Easy for users to navigate to different sections.
Documentation only PR, no builds affected