Skip to content

Conversation

@LoopFruits
Copy link
Contributor

Easy for users to navigate to different sections.

Documentation only PR, no builds affected

easy for users to navigate to different sections.

Documentation only PR, no builds affected
@LoopFruits LoopFruits requested review from a team as code owners October 13, 2022 21:54
Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor changes needed for consistency. The rest looks good!

LoopFruits and others added 2 commits October 14, 2022 12:13
Co-authored-by: Param Siddharth <30315706+paramsiddharth@users.noreply.github.com>
Co-authored-by: Param Siddharth <30315706+paramsiddharth@users.noreply.github.com>
@JimmyJammer
Copy link

FWIW, GitHub automatically generates a Table of Contents for these if you just click on the upper-left menu button near the filename in the viewing panel:

Screen Shot 2022-10-20 at 10 47 41 AM

The beauty of GitHub's automatic solution is that it will never become out-of-date. ✨

With that in mind, do we still want to add this? It is undoubtedly more visible, so it's just a question of if that visibility outweighs the long-term maintenance burden. 🤷‍♂️ 🤔

@paramsiddharth
Copy link
Member

@JimmyJammer FWIW, GitHub automatically generates a Table of Contents for these if you just click on the upper-left menu button near the filename in the viewing panel:

Screen Shot 2022-10-20 at 10 47 41 AM

The beauty of GitHub's automatic solution is that it will never become out-of-date. ✨

With that in mind, do we still want to add this? It is undoubtedly more visible, so it's just a question of if that visibility outweighs the long-term maintenance burden. 🤷‍♂️ 🤔

Good point! As amazing as this feature is, I think we'd still go with considering this PR for this particular repository. "More visibility" isn't exactly going to be the criterion, but I think the design team intended on having this added to the README.

Nevertheless, thank you for pointing out the fact that there's a button that automatically generates the ToC for us! It will now be helpful for me every time I navigate through GitHub repositories. 🤗

@JamesMGreene
Copy link
Contributor

Forgot I was logged into my test account there. 😊

@paramsiddharth paramsiddharth merged commit 78bbc02 into main Oct 20, 2022
@paramsiddharth paramsiddharth deleted the LoopFruits-patch-1 branch October 20, 2022 16:58
@paramsiddharth
Copy link
Member

Forgot I was logged into my test account there. 😊

@JamesMGreene Haha, big reveal, James! 😁 Your test account just got a new follower~! Had I known it was you, I'll probably let you make the final decision instead of what was proposed in the bugbash. Sorry about that!

@JamesMGreene
Copy link
Contributor

I'm fine with the change! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants