Skip to content

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Feb 3, 2018

  • Add of ChangeLog entry.

@hippo91
Copy link
Contributor Author

hippo91 commented Feb 3, 2018

@PCManticore is there a problem with Travis and python3.x or did i miss something?

@ceridwen
Copy link
Contributor

ceridwen commented Feb 3, 2018

Looks like it's failing because of pylint failures and an unexpected success. Unfortunately the test output doesn't tell us what the unexpected success is. Can you try running the tests locally to figure out what the unexpected success is?

@ceridwen
Copy link
Contributor

ceridwen commented Feb 3, 2018

Actually, it might be this bug: #472

In which case it's a preexisting issue and nothing to do with your pull request.

@brycepg
Copy link
Contributor

brycepg commented Feb 3, 2018

It is most likely #472. We have had this issue in master, except I removed the @unittest.expectedfailure. The test is unreliably passing and failing depending on the CI and something else (we think inference tips being overwritten by each other). If it is this test, I think using @unittest.skip is the best option at the moment.

@PCManticore
Copy link
Contributor

@brycepg is right, we can disable the test for now. @hippo91 this is failing the linting, otherwise it is good to go.

@hippo91
Copy link
Contributor Author

hippo91 commented Feb 4, 2018

Thanks @ceridwen , @brycepg and @PCManticore . I replace the decorator @unittest.expectedfailure with @unittest.skip and the CI is ok!.
I merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants