This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Add tests and fixed bug where new 209 was failing #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add failing test for new D209 and fixed the logic.
keleshev
pushed a commit
that referenced
this pull request
Mar 11, 2014
Add tests and fixed bug where new 209 was failing
|
Released it to PyPI as 0.3.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I incorrectly modified the logic on D209 in my previous PR and the tests did not catch it. So I added tests to cover both old and new 209 cases and fixed the problem.
I also added testing for D100 while at it.
Sorry for the miss...