Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 11, 2025

What does this PR do?

Fixes linting errors related to S105, S106, and S107. Remove from ignore-list in pyproject.toml.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21196.org.readthedocs.build/en/21196/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package package labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (3bcfc17) to head (bef2f36).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21196    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         270      270            
  Lines       23822    23822            
========================================
- Hits        20795    20651   -144     
- Misses       3027     3171   +144     

@deependujha deependujha merged commit a883890 into Lightning-AI:master Oct 29, 2025
111 of 112 checks passed
@matsumotosan matsumotosan deleted the flake8-password-rules branch October 30, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants