Skip to content

Conversation

PenguinDevs
Copy link
Contributor

Summary

This is a follow-up of pull request #634 which was to fix the issue of Pycord bulk upserting global commands every single time the bot was started. This pull request is a follow-up for it to fix the issue of subcommands causing an error in the register_commands method.

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (squash) December 30, 2021 19:46
@Dorukyum Dorukyum requested review from Dorukyum and Middledot January 1, 2022 11:29
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby added this to the v2.1 milestone Jan 7, 2022
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority Merge with squash labels Jan 7, 2022
@BobDotCom
Copy link
Contributor

Since I've been working on my own version of application command registration, I'm going to close this PR for now and you can apply the fix to my PR if the issue still exists. I'll provide a link to it here once I open it.

@BobDotCom BobDotCom closed this Jan 9, 2022
auto-merge was automatically disabled January 9, 2022 20:05

Pull request was closed

@BobDotCom
Copy link
Contributor

Here's my PR: #759

@VincentRPS VincentRPS removed this from the v2.1 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants