-
-
Notifications
You must be signed in to change notification settings - Fork 482
Command registration rewrite #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e41f17
to
1fd07da
Compare
Generally it currently it doesn't act as smart as it could. It still often re-creates all commands even trough I didn't modified any command. With a few restart I reached the 200 command creation limit. An option for not deleting missing commands would be useful in case a cog isn't loaded or a command is added/updated later on runtime. A perfect flow would be: This also applies to multi process bots: |
I haven't encountered this at all, are you sure? The whole reason this was rewritten was because the commands shouldn't be bulk registered every time if they don't need to be. This setup should utilize the minimum amount of registrations possible, though it will hit its limits if you start up without commands a couple times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Forgot to make one change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Rewrites command registration to actually be efficient and smart.
Checklist
Needs testing
And maybe more...
Unfinished
And maybe more...
If there's anything I need to add just let me know.
If anyone would like to contribute, just make a PR on the
feature/command-registration
branch.