Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

DivyanshK12
Copy link
Contributor

Description

Refactored code in JSONtoExcel.py, making it a part of function and provided a test case and made it more reusable

Fixes #94

None

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@AdityaJ7 AdityaJ7 merged commit 04b1b8f into Python-World:master Oct 1, 2020
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 1, 2020

@all-contributors add @dkarmy12 for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @dkarmy12! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants