Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

meghanacosmos
Copy link
Contributor

Description

This PR includes py script to convert JSON file to excel file.

Fixes #(issue_no)

#35

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements.txt file should only contain this:

pandas==1.1.2

Everything else works fine nice work

@meghanacosmos
Copy link
Contributor Author

Sure, I'll update that!

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 1, 2020

Sure, I'll update that!

The heading in your readme file is incorrect please check that

@meghanacosmos
Copy link
Contributor Author

Sure, I'll update that!

The heading in your readme file is incorrect please check that

Updated it just now!

@AdityaJ7 AdityaJ7 requested review from AdityaJ7 and tusharnankani and removed request for tusharnankani October 1, 2020 13:04
@mergify mergify bot merged commit 870cd33 into Python-World:master Oct 1, 2020
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 1, 2020

@all-contributors please add @meghana-12 for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @meghana-12! 🎉

@DivyanshK12 DivyanshK12 mentioned this pull request Oct 1, 2020
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants