Skip to content

Commit 4cb7978

Browse files
committed
Fix longstanding bug in qualifiers
1 parent 2014596 commit 4cb7978

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

wikidata_bot_framework/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -545,21 +545,19 @@ def process(self, output: Output, item: EntityPage) -> bool:
545545
) in extra_prop_data.qualifiers.copy().items():
546546
for qualifier_data in qualifiers.copy():
547547
qualifier = qualifier_data.claim
548-
if qualifier not in new_claim.qualifiers.get(
549-
qualifier_prop, []
550-
) and (
548+
if not new_claim.qualifiers.get(qualifier_prop, []) and (
551549
self.whitelisted_claim(extra_prop_data)
552550
or self.whitelisted_qualifier(
553551
extra_prop_data, qualifier
554552
)
555553
):
554+
add_qualifier_locally(new_claim, qualifier)
556555
re_cycle |= self.processed_hook(
557556
item,
558557
ProcessReason.missing_qualifier_property,
559558
claim=extra_prop_data,
560559
qualifier=qualifier_data,
561560
)
562-
add_qualifier_locally(new_claim, qualifier)
563561
acted = True
564562
else:
565563
for existing_qualifier in new_claim.qualifiers[

0 commit comments

Comments
 (0)