WIP: Add multiple files support #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stop flake8 messages about asserts * Add hash to each solution for comparision * Further enhance the migration script * Create upload model * Make the view work again (with single file) * Fix minor bug in the notification's HTML
|
This pull request introduces 3 alerts when merging edc0af7 into 5ae871d - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 8758eb7 into 5ae871d - view on LGTM.com new alerts:
|
- Add tree view for files in HTML - Change font CSS to work with our file view - Add zip extractor - Better error handling
itraviv
reviewed
Aug 19, 2020
| for cls in self.__class__.__subclasses__(): | ||
| logger.debug(f'Trying extractor: {cls.__name__}') | ||
| extractor = cls(to_extract=self.to_extract) | ||
| if extractor.can_extract(): |
There was a problem hiding this comment.
-
what happens when multiple extractors can extract? you will continue to get
(solution_id, files)on the same file and you may encounter a weird behavior wherefor (solution_id, files) in extractor:will give you duplicates. -
another thing, i think it will be best if we could have a log entry saying "i couldn't extract this: {filename}"
my suggestion is to do something like:
for cls ....:
if extractor.can_extract():
for ...
yield ...
return
logger.warning(f"couldn't find extractor for {self.to_extract}")
gal432
approved these changes
Aug 19, 2020
…eCourse/lms into multiple-files-support
|
Solved #125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #125