Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TID1500writer doesn't read all json attributes into DICOM SR #109

Closed
che85 opened this issue Nov 3, 2016 · 2 comments · Fixed by #110
Closed

TID1500writer doesn't read all json attributes into DICOM SR #109

che85 opened this issue Nov 3, 2016 · 2 comments · Fixed by #110
Assignees
@che85
Labels
bug high priority SR

Comments

@che85
Copy link
Member

che85 commented Nov 3, 2016 •
edited
Loading

Missing:

  • SeriesDescription
  • InstanceNumber
  • CompletionFlag
  • VerificationFlag
@che85 che85 self-assigned this Nov 3, 2016
@che85
Copy link
Member Author

che85 commented Nov 3, 2016

@fedorov I assume, that we use those attributes in json in order to save it into the DICOM SR, right?[1]

This code [2] copies information from the compositeContext. Which one should we use? I suggest to overwrite that information if it's available in json. Otherwise we don't need those meta information.

[1] https://github.com/QIICR/dcmqi/blob/master/doc/sr-tid1500-ct-liver-example.json#L4-L6
[2] https://github.com/QIICR/dcmqi/blob/master/apps/sr/tid1500writer.cxx#L239-L241

@che85
Copy link
Member Author

che85 commented Nov 3, 2016

@fedorov my fault. I looked at the wrong output.json file ....no need to reply to my last comment

che85 added a commit to che85/dcmqi that referenced this issue Nov 4, 2016
@che85
ENH: Added missing attributes (issue QIICR#109)
13c352e
@che85 che85 mentioned this issue Nov 4, 2016
Merged
che85 added a commit to che85/dcmqi that referenced this issue Nov 7, 2016
@che85
ENH: Added missing attributes (issue QIICR#109)
bc2880f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@che85 che85

Labels
bug high priority SR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reading DICOM SR and creation of JSON with its attributes and measurements che85/dcmqi
1 participant
@che85