Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper testing #9

Closed
13 tasks done
che85 opened this issue May 31, 2016 · 0 comments · Fixed by #154
Closed
13 tasks done

Add proper testing #9

che85 opened this issue May 31, 2016 · 0 comments · Fixed by #154
Assignees
@che85
Labels
enhancement PM SEG

Comments

@che85
Copy link
Member

che85 commented May 31, 2016 •
edited
Loading

Specific sub-tasks:

Segmentations

  • add test DICOM data and baselines (@fedorov)
  • seg2itk conversion test: confirm the images are equivalent
  • itk2seg conversion test:
    • run dciodvfy on the output
    • confirm round-trip test is working

Parametric Maps

  • pmap2itk conversion test: confirm the images are equivalent
  • itk2pmap conversion test:
    • run dciodvfy on the output
    • confirm round-trip test is working

Structured Report

  • tid1500reader test
  • tid1500writer test
    • run dciodvfy on the output
    • confirm round-trip test is working
@che85 che85 self-assigned this May 31, 2016
@fedorov fedorov mentioned this issue Jun 2, 2016
Closed
che85 added a commit to che85/dcmqi that referenced this issue Oct 20, 2016
@che85
BUG: fixed segmentation round trip test (issue QIICR#9)
fcf672f 
- added missing attributes
- fixed json comparison script (for the reference ChannelIQ/jsoncompare#8 and ChannelIQ/jsoncompare#9)
che85 added a commit to che85/dcmqi that referenced this issue Oct 24, 2016
@che85
ENH: added dciodvfy test for segmentation (issue QIICR#9)
238ebf1
@che85 che85 mentioned this issue Oct 24, 2016
Merged
fedorov added a commit that referenced this issue Oct 25, 2016
@fedorov
Merge pull request #106 from che85/dciodvfy
6fe150e 
ENH: added dciodvfy test for segmentation (issue #9)
che85 added a commit to che85/dcmqi that referenced this issue Nov 21, 2016
@che85
ENH: added pmap/sr dciodvfy tests and sr meta roundtrip test (issue Q…
f60a169 
…IICR#9)

- also set dependencies of dciodvfy tests
- added prefix parameter for output of paramap2itkimage
@che85 che85 mentioned this issue Nov 21, 2016
Merged
@che85 che85 closed this as completed Dec 5, 2016
@che85 che85 reopened this Dec 5, 2016
@che85 che85 closed this as completed Jan 18, 2017
che85 added a commit to che85/dcmqi that referenced this issue Feb 27, 2017
@che85
ENH: added pmap/sr dciodvfy tests and sr meta roundtrip test (issue Q…
d99dcb8 
…IICR#9)

- also set dependencies of dciodvfy tests
- added prefix parameter for output of paramap2itkimage
che85 added a commit to che85/dcmqi that referenced this issue Feb 28, 2017
@che85
ENH: added pmap/sr dciodvfy tests and sr meta roundtrip test (issue Q…
20399b3 
…IICR#9)

- also set dependencies of dciodvfy tests
- added prefix parameter for output of paramap2itkimage
che85 added a commit to che85/dcmqi that referenced this issue Mar 1, 2017
@che85
ENH: added pmap/tid1500 dciodvfy and meta roundtrip tests (issue QIICR#9
967b33b 
)

* added prefix parameter for output of paramap2itkimage
* added the following attributes to meta output (issue QIICR#91):
  * added DerivationCode
  * SourceImageDiffusionBValues
  * MeasurementMethod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@che85 che85

Labels
enhancement PM SEG
Projects
None yet
Milestone
No milestone
1 participant
@che85